https://pantsbuild.org/ logo
Powered by
#development
  • b

    billowy-beach-68498

    12/08/2016, 12:51 AM
    i see. so we share OSX shards with other users
  • r

    rough-minister-58256

    12/08/2016, 12:51 AM
    yeah they come from the global travis pool
  • b

    billowy-beach-68498

    12/08/2016, 12:51 AM
    makes sense
  • r

    rough-minister-58256

    12/08/2016, 12:51 AM
    whereas for linux, we have 15 reserved just for our use
  • b

    billowy-beach-68498

    12/08/2016, 1:05 AM
    hmm, I messed up git commit message
  • b

    billowy-beach-68498

    12/08/2016, 1:05 AM
    sorry guys
  • b

    billowy-beach-68498

    12/08/2016, 1:05 AM
    let me amend it
  • r

    rough-minister-58256

    12/08/2016, 1:05 AM
    😮
  • r

    rough-minister-58256

    12/08/2016, 1:05 AM
    nbd - and be careful with amend after push to master
  • b

    billowy-beach-68498

    12/08/2016, 1:06 AM
  • b

    billowy-beach-68498

    12/08/2016, 1:06 AM
    Amending the message of the most recently pushed commit
  • b

    billowy-beach-68498

    12/08/2016, 1:06 AM
    I am gonna follow ^ section
  • r

    rough-minister-58256

    12/08/2016, 1:07 AM
    as long as no one has pulled in the window of your history rewrite, it shoudl be fine
  • b

    billowy-beach-68498

    12/08/2016, 1:14 AM
    i think it's fixed
  • l

    limited-country-20626

    12/08/2016, 6:32 PM
    I know you all well enough that I trust you had sufficient reason, but I want to make a plea to not force push to public repos if there is any choice in the matter. That can really cause issues with publicly available history and is tough to catch in the circumstances where it does cause problems. I am actually surprised that is enabled on Pants repo, I believe Github has a lever to ban them.
  • b

    billowy-beach-68498

    12/08/2016, 6:44 PM
    yeah I agree. But is there an alternative way of amending commit message after pushed to github? What happened yesterday was I didn't copy the PR description in "squash and merge" step, thus I didn't realize the mistake until the commit is in github.
  • f

    fancy-queen-20734

    12/08/2016, 6:55 PM
    Not really
  • w

    wide-energy-11069

    12/08/2016, 6:57 PM
    there’s git push -f, but i think it’s prohibited
  • f

    fancy-queen-20734

    12/08/2016, 6:58 PM
    I think that’s what @billowy-beach-68498 was saying they used
  • f

    fancy-queen-20734

    12/08/2016, 6:58 PM
    after amending the commit message
  • b

    billowy-beach-68498

    12/08/2016, 6:59 PM
    yeah, I used git push --force, which should be same as git push -f
  • r

    rough-minister-58256

    12/08/2016, 7:05 PM
    I wonder if we’d be better off using a tool to land PRs ratehr than the web view
  • r

    rough-minister-58256

    12/08/2016, 7:05 PM
    then we’d be able to automatically construct the commit messages more relaibly, etc
  • r

    rough-minister-58256

    12/08/2016, 7:05 PM
    land from the web is really nice and all, but error prone
  • w

    witty-crayon-22786

    12/08/2016, 7:39 PM
    yea.
  • w

    witty-crayon-22786

    12/10/2016, 1:04 AM
    the externs are going a bit nuts... sigh. 3 more in this review i think.
  • w

    witty-crayon-22786

    12/10/2016, 1:04 AM
    hopefully almost done though?
  • w

    witty-crayon-22786

    12/10/2016, 2:46 AM
  • w

    witty-crayon-22786

    12/10/2016, 2:49 AM
    seems to require about 2G less memory... more to do though probably.
  • w

    witty-crayon-22786

    12/10/2016, 2:53 AM
    ...slower though. blargh.
1...203204205...906Latest