https://pantsbuild.org/ logo
Powered by
#development
  • r

    rough-minister-58256

    12/07/2016, 2:21 AM
    and ofc rustup utterly fails to work on centos5
  • r

    rough-minister-58256

    12/07/2016, 2:21 AM
    due to SSL cert crap
  • r

    rough-minister-58256

    12/07/2016, 2:21 AM
    ugh
  • r

    rough-minister-58256

    12/07/2016, 2:21 AM
  • r

    rough-minister-58256

    12/07/2016, 2:22 AM
    and can’t just hack it in, because invoking it also calls curl which fails recursively w/ ssl errors
  • r

    rough-minister-58256

    12/07/2016, 2:27 AM
    I suppose we could cowboy https://github.com/pantsbuild/pants/pull/4127 in and then revert if it breaks
  • r

    rough-minister-58256

    12/07/2016, 2:38 AM
    will wait for a second set of eyes, but thinking we land this and see what happens in CI - I’ve verified to the extent possible that it all works on OSX (but fails to x-compile)
  • r

    rough-minister-58256

    12/07/2016, 3:09 AM
    ah, CI revealed an issue after the rev bump
  • r

    rough-minister-58256

    12/07/2016, 3:10 AM
    Copy code
    error: cannot produce dylib for `engine v0.0.1 (file:///home/travis/build/pantsbuild/pants/src/rust/engine)` as the target `x86_64-unknown-linux-musl` does not support these crate types
  • r

    rough-minister-58256

    12/07/2016, 3:10 AM
    hrm
  • r

    rough-minister-58256

    12/07/2016, 3:48 AM
    ah need 
    crate-type=[”staticlib”]
  • w

    witty-crayon-22786

    12/07/2016, 4:19 AM
    @rough-minister-58256 : back, sorry
  • r

    rough-minister-58256

    12/07/2016, 4:25 AM
    nbd
  • w

    witty-crayon-22786

    12/07/2016, 4:38 AM
    i have the same feedback as John on that one
  • r

    rough-minister-58256

    12/07/2016, 4:39 AM
    yep, trying to figure out a good way to test end to end tho before actually publishing
  • w

    witty-crayon-22786

    12/07/2016, 4:39 AM
    ...looks like the sha probably changed, but wasn't committed
  • r

    rough-minister-58256

    12/07/2016, 4:39 AM
    cp: cannot stat ‘/home/travis/build/pantsbuild/pants/src/rust/engine/target/x86_64-unknown-linux-musl/release/libengine.so’: No such file or directory
  • r

    rough-minister-58256

    12/07/2016, 4:39 AM
    i think a path thing isn’t aligning or something
  • r

    rough-minister-58256

    12/07/2016, 4:40 AM
    ah it’d probably be libengine.a
  • w

    witty-crayon-22786

    12/07/2016, 4:40 AM
    ah. yea.
  • r

    rough-minister-58256

    12/07/2016, 4:40 AM
    weird that it doesn’t fail the build when the cargo build fails
  • r

    rough-minister-58256

    12/07/2016, 4:40 AM
    is that by design?
  • r

    rough-minister-58256

    12/07/2016, 4:40 AM
    err, the steps aroudn cargo
  • w

    witty-crayon-22786

    12/07/2016, 4:40 AM
    i introduced a 
    cargo build || exit 1
    , but it got removed again =/
  • r

    rough-minister-58256

    12/07/2016, 4:40 AM
    are we missing a 
    set -e
    ?
  • w

    witty-crayon-22786

    12/07/2016, 4:41 AM
    yea, John doesn't generally add them. don't know why.
  • r

    rough-minister-58256

    12/07/2016, 4:41 AM
    set -euxo pipefail
  • r

    rough-minister-58256

    12/07/2016, 4:41 AM
    ah
  • r

    rough-minister-58256

    12/07/2016, 5:31 AM
    hmm, better luck with the .a extension but then:
    Copy code
    OSError: cannot load library /home/travis/.cache/pants/bin/native-engine/linux/x86_64/9f290c431bae455b4ec49ee23fb071edb0eef136/native-engine: /home/travis/.cache/pants/bin/native-engine/linux/x86_64/9f290c431bae455b4ec49ee23fb071edb0eef136/native-engine: invalid ELF header
  • r

    rough-minister-58256

    12/07/2016, 7:14 AM
    seems dlopen is incompatible with static libs
1...199200201...906Latest