creating FFI handles for each thing and sometimes assigning IDs to them

also, i think a lot more time could be shaved off of

extern_store_list

if everything was lifted into keys, so that rust could implement the merge

the Runnable work will be beneficial, but perhaps not hugely: while the

file_digest

and

scan_directory

task function are the most expensive (about 22% of total runtime together), it's not all IO

there is ignored file filtering, and etc

(although we do have about 10% of time spent in

file.read

, which should be parallelizable)

@billowy-beach-68498 : my feeling is that you should dive into the runnable work

and we can continue to profile

Sounds good.

@fancy-queen-20734 : i'm sure it's just the sha... but we can't merge from the webui while there are conflicts... and the new sha will be a brand new sha

yep

trace of the current v2 engine list:: breakage in master:

Exception message: Build graph construction failed for (SingleAddress(directory=u'geoduck/web/webtool', name=u'tests'), Select(Collection.of(HydratedTarget))) @ None:
Computing =Collection.of(HydratedTarget) for SingleAddress(directory=u'geoduck/web/webtool', name=u'tests')
  Computing =Collection.of(HydratedTarget) for SingleAddress(directory=u'geoduck/web/webtool', name=u'tests')
    Computing =HydratedTarget for SingleAddress(directory=u'geoduck/web/webtool', name=u'tests')
      Computing =HydratedTarget for geoduck/web/webtool:tests
        Computing =HydratedTarget for geoduck/web/webtool/src/test/scala:scala

i saw that post and was thinking about that as well. super tempting, but i think we'd have to reimplement all the file access tracking.

the lower bound here is... pretty low

wat... that target depends on itself.

...and is empty

re: that breakage... bad target appears to be fixed in master

...oh, lies. fixing it now though.

@rough-minister-58256 : commented on that one

saw

i'll look at removing the libc dep

gonna try rebuilding the bin on a c5 VM to see if it will link properly

looks like it is easy to drop

oh cool

@rough-minister-58256 : https://github.com/pantsbuild/pants/pull/4124

...ah, crap. some junk in there.

oh nice

updated

🚢