https://pantsbuild.org/ logo
Powered by
#development
  • w

    witty-crayon-22786

    08/26/2016, 9:48 PM
    ...actually, it can't be more efficient.
  • b

    billowy-beach-68498

    08/26/2016, 9:49 PM
    yeah i was wondering how does —transitive implemented in test-changed
  • b

    billowy-beach-68498

    08/26/2016, 9:49 PM
    it just feels like dependees
  • r

    rough-minister-58256

    08/26/2016, 9:49 PM
    yeah, 
    —changed-include-dependees=transitive
  • r

    rough-minister-58256

    08/26/2016, 9:49 PM
    yeah probably similar
  • w

    witty-crayon-22786

    08/26/2016, 9:49 PM
    so yea, that's going to cause everything to be parsed
  • w

    witty-crayon-22786

    08/26/2016, 9:49 PM
    ...so... hm
  • b

    billowy-beach-68498

    08/26/2016, 9:51 PM
    even if we implement dependees entirely in v2 in the future, we may not want to cache that productgraph since it is too large?
  • r

    rough-minister-58256

    08/26/2016, 9:51 PM
    I’m guessing pre-RB#4114, this all “jsut worked” because it was just addressing the regular old 
    AddressMapper
  • w

    witty-crayon-22786

    08/26/2016, 9:52 PM
    @billowy-beach-68498 : we can cache it... that's already what happens during 
    ./pants list ::
  • r

    rough-minister-58256

    08/26/2016, 9:52 PM
    yeah
  • b

    billowy-beach-68498

    08/26/2016, 9:52 PM
    oh right
  • r

    rough-minister-58256

    08/26/2016, 9:53 PM
    particularly in CI, the crossplay of these goals will benefit each other by warming the PG
  • r

    rough-minister-58256

    08/26/2016, 9:53 PM
    for the 
    changed
    + 
    list
    case etc
  • b

    billowy-beach-68498

    08/26/2016, 9:53 PM
    make sense
  • r

    rough-minister-58256

    08/26/2016, 9:53 PM
    the same should probably be done for 
    dependees
    , but its nto super critial right now
  • r

    rough-minister-58256

    08/26/2016, 9:53 PM
    if there was a quick way to just patch this up for the time being, I think we can circle back to it
  • r

    rough-minister-58256

    08/26/2016, 9:54 PM
    we just need functionality here - not necessarily full perf optimization; and we’re gonna end up with something anyway for 
    changed
  • b

    billowy-beach-68498

    08/26/2016, 9:57 PM
    product graph is mutable right?
  • b

    billowy-beach-68498

    08/26/2016, 9:57 PM
    so is legacybuildgraph?
  • r

    rough-minister-58256

    08/26/2016, 9:58 PM
    PG is mutable, but its contents are not; LBG is mutable and so are its contents
  • r

    rough-minister-58256

    08/26/2016, 9:58 PM
    it may just make sense to defer fixing dependees until after the 
    changed
    patch for now - unless a quick fix is apparent
  • b

    billowy-beach-68498

    08/26/2016, 10:00 PM
    who is working on changed patch?
  • w

    witty-crayon-22786

    08/26/2016, 10:04 PM
    kris is
  • b

    billowy-beach-68498

    08/26/2016, 10:08 PM
    ok, I will think about some easy ways to fix, if not, I will talk with Kris about his patch.
  • b

    billowy-beach-68498

    08/26/2016, 10:09 PM
    @rough-minister-58256 sounds good?
  • r

    rough-minister-58256

    08/26/2016, 10:09 PM
    sgtm!
  • r

    rough-minister-58256

    08/27/2016, 10:52 PM
    so I have a fix for the 
    list
    case that’s a natural bit of doing alternate_target_roots for the v2 engine
  • r

    rough-minister-58256

    08/27/2016, 10:54 PM
    and I see a pretty clear path for 
    dependees
    and also optimizing 
    list
    (Stu’s past thought of ‘list doesnt need a BuildGraph’/engine-backed list)
  • r

    rough-minister-58256

    08/27/2016, 11:01 PM
    Copy code
    [illuminati pants (kwlzn/engine/cached_changed)]$ time ./pants -ldebug --enable-v2-engine --changed2-parent=HEAD~2 list
...
DEBUG] changed_request is: ChangedRequest(parent='HEAD~2', diffspec=None, include_dependees='none', fast=False)
DEBUG] Executing: git --git-dir=/Users/kwilson/dev/pants/.git --work-tree=/Users/kwilson/dev/pants diff --name-only HEAD -- /Users/kwilson/dev/pants
DEBUG] Executing: git --git-dir=/Users/kwilson/dev/pants/.git --work-tree=/Users/kwilson/dev/pants diff --name-only HEAD~2...HEAD -- /Users/kwilson/dev/pants
DEBUG] Executing: git --git-dir=/Users/kwilson/dev/pants/.git --work-tree=/Users/kwilson/dev/pants ls-files --other --exclude-standard -- /Users/kwilson/dev/pants
DEBUG] changed files: set([u'src/python/pants/engine/engine.py', u'src/python/pants/build_graph/source_mapper.py', u'src/python/pants/bin/goal_runner.py', u'src/python/pants/scm/change_calculator.py', u'src/python/pants/bin/engine_initializer.py'])
DEBUG] ran 173 scheduling iterations in 1.212234 seconds. there have been 9412 total steps for 5824 total nodes.
DEBUG] changed address: src/python/pants/scm:change_calculator
DEBUG] changed address: src/python/pants/engine:engine
DEBUG] changed address: src/python/pants/bin:bin
DEBUG] changed address: src/python/pants/build_graph:build_graph
...
src/python/pants/build_graph:build_graph
src/python/pants/engine:engine
src/python/pants/bin:bin
src/python/pants/scm:scm
1...158159160...906Latest