https://pantsbuild.org/ logo
Powered by
#development
  • w

    witty-crayon-22786

    08/23/2016, 11:57 PM
    ./pants changed --parent=master
    -> 
    ./pants --changed-parent=master list
  • w

    witty-crayon-22786

    08/23/2016, 11:57 PM
    or
  • r

    rough-minister-58256

    08/23/2016, 11:57 PM
    ahh
  • w

    witty-crayon-22786

    08/23/2016, 11:57 PM
    ./pants test-changed --parent=master
    -> 
    ./pants --changed-parent=master test
  • w

    witty-crayon-22786

    08/23/2016, 11:57 PM
    ie, the global option would change the target roots before goals began
  • w

    witty-crayon-22786

    08/23/2016, 11:58 PM
    ...would kill special casing for each of those.
  • r

    rough-minister-58256

    08/23/2016, 11:58 PM
    makes sense
  • w

    witty-crayon-22786

    08/23/2016, 11:58 PM
  • r

    rough-minister-58256

    08/24/2016, 6:44 PM
    @billowy-beach-68498 I thought we decided that it was a bad idea to subclass tarfile just to override a single method and instead wanted to vendor the entire tarfile.py into our sources?
  • r

    rough-minister-58256

    08/24/2016, 6:45 PM
    I think within the 2.7.x versions of python it’s fine - but as soon as someone attempts to run this with python3 etc.
  • r

    rough-minister-58256

    08/24/2016, 6:45 PM
    tho we don’t exactly guarantee py3k compatibility today - it’s assumed and “best effort"
  • r

    rough-minister-58256

    08/24/2016, 6:48 PM
    Copy code
    [illuminati throwaway]$ diff -u tarfile{2,3}.py | diffstat
 tarfile3.py | 1540 ++++++++++++++++++++++++++++--------------------------------
 1 file changed, 736 insertions(+), 804 deletions(-)
  • b

    billowy-beach-68498

    08/24/2016, 6:53 PM
    I think Benjy’s point is copying the entire module is worse, and i think you agree with him?
  • r

    rough-minister-58256

    08/24/2016, 6:54 PM
    yeah - for 2.7.x interpreters. I guess the bigger question is: are we ok w/ potentially breaking python3 with this change?
  • b

    billowy-beach-68498

    08/24/2016, 6:54 PM
    my hope is we will eventually get rid of this subclassing
  • b

    billowy-beach-68498

    08/24/2016, 6:55 PM
    once we have improve the cache in pants?
  • r

    rough-minister-58256

    08/24/2016, 6:55 PM
    sure
  • b

    billowy-beach-68498

    08/24/2016, 6:56 PM
    but from yesterday’s standup I thought we want to stick with the subclass and override approach at least for now or am I missing anything?
  • r

    rough-minister-58256

    08/24/2016, 6:56 PM
    I wonder if we shouldn’t at least put in a 2.7.x specific path here
  • r

    rough-minister-58256

    08/24/2016, 6:57 PM
    something like
  • r

    rough-minister-58256

    08/24/2016, 6:57 PM
    Copy code
    import six

if six.PY2:
  class TarFile(...):
  ...
else:
  from tarfile import TarFile
  • r

    rough-minister-58256

    08/24/2016, 6:57 PM
    what do you think?
  • b

    billowy-beach-68498

    08/24/2016, 6:58 PM
    yeah, i am ok with that
  • b

    billowy-beach-68498

    08/24/2016, 6:58 PM
    the change i made is meant for python2 anyway
  • r

    rough-minister-58256

    08/24/2016, 6:58 PM
    ya
  • r

    rough-minister-58256

    08/24/2016, 6:58 PM
    so at least we’d be explicit
  • b

    billowy-beach-68498

    08/24/2016, 6:59 PM
    yeah, that’s better. I will make the change
  • b

    billowy-beach-68498

    08/24/2016, 6:59 PM
    thanks!
  • r

    rough-minister-58256

    08/24/2016, 6:59 PM
    sweet
  • r

    rough-minister-58256

    08/24/2016, 7:02 PM
    commented and ship’d - might be good to solicit some broader reviews in #general on this one tho in place of Benjy
1...156157158...906Latest