https://pantsbuild.org/ logo
Powered by
#development
  • f

    fancy-queen-20734

    08/16/2016, 10:03 PM
    maybe we could do that?
  • f

    fancy-queen-20734

    08/16/2016, 10:03 PM
    kindof icky though
  • w

    witty-crayon-22786

    08/16/2016, 10:03 PM
    please confirm that 
    attrs
    is not going to work for us
  • r

    rough-minister-58256

    08/16/2016, 10:03 PM
    @witty-crayon-22786: did you see the poc impl?
  • r

    rough-minister-58256

    08/16/2016, 10:03 PM
    its <10 LoC
  • w

    witty-crayon-22786

    08/16/2016, 10:03 PM
    right, and then you add features to it
  • f

    fancy-queen-20734

    08/16/2016, 10:05 PM
    neat, so attrs is like django models but building attr classes rather than ORMs
  • r

    rough-minister-58256

    08/16/2016, 10:05 PM
    mm.. or not
  • r

    rough-minister-58256

    08/16/2016, 10:05 PM
    imo, we should be aiming for a dead simple lightweight impl here
  • r

    rough-minister-58256

    08/16/2016, 10:07 PM
    worth a closer look I suppose - I skimmed and it appeared more convoluted to me than I think we might want given we’re creating millions of these things
  • r

    rough-minister-58256

    08/16/2016, 10:09 PM
    does support slots, but would have to be defined per-type-subclass afaict: https://attrs.readthedocs.io/en/stable/examples.html#slots
  • r

    rough-minister-58256

    08/16/2016, 10:09 PM
    and the way it does that is with a decorator, which adds function call overhead, etc
  • r

    rough-minister-58256

    08/16/2016, 10:10 PM
    lets bench it
  • r

    rough-minister-58256

    08/16/2016, 10:13 PM
    Copy code
    $ /usr/bin/time -l ./bench_attrs.py 
       30.32 real        30.15 user         0.08 sys
   5713920  maximum resident set size
  • r

    rough-minister-58256

    08/16/2016, 10:13 PM
    faster than namedtuple, slightly slower than datatype2
  • r

    rough-minister-58256

    08/16/2016, 10:14 PM
    and uses more memory than all of the above
  • r

    rough-minister-58256

    08/16/2016, 10:16 PM
    interestingly enough, attrs is faster without `slots=True`:
  • r

    rough-minister-58256

    08/16/2016, 10:16 PM
    Copy code
    27.73 real        27.43 user         0.15 sys
   5529600  maximum resident set size
  • r

    rough-minister-58256

    08/16/2016, 10:17 PM
    but still uses more memory
  • r

    rough-minister-58256

    08/16/2016, 10:17 PM
    presumably that’s like pure function/datastructure overhead vs datatype2
  • r

    rough-minister-58256

    08/16/2016, 10:20 PM
    guessing it’ll be easier to pickle a more straightforward slots obj too vs a potentially meta’d out attr
  • w

    witty-crayon-22786

    08/16/2016, 10:21 PM
    @rough-minister-58256: that will need to implement equals/hashcode
  • r

    rough-minister-58256

    08/16/2016, 10:21 PM
    ya
  • f

    fancy-queen-20734

    08/16/2016, 10:46 PM
    @rough-minister-58256: are you looking at implementing that, or should I update my rb w/ an impl? I’m working on my validation stuff
  • r

    rough-minister-58256

    08/16/2016, 10:47 PM
    entirely up to you - happy to ship what youve got now and circle back and impl this idea, or you can in your RB if you’re up for it
  • r

    rough-minister-58256

    08/16/2016, 10:48 PM
    seems like it might just undo a fair bit of what you have in this RB tho, so if you’re game then updating the RB seems like the most efficient path that I can see
  • f

    fancy-queen-20734

    08/16/2016, 10:48 PM
    makes sense
  • r

    rough-minister-58256

    08/16/2016, 10:53 PM
    @User uploaded a file:

    Pasted image at 2016-08-16, 3:52 PM▾

  • r

    rough-minister-58256

    08/16/2016, 10:53 PM
    so afaict, the whole BuildGraph._target_by_address->Address._build_graph cycle seems problematic for GC
  • r

    rough-minister-58256

    08/16/2016, 10:54 PM
    furthermore, it appears that 
    memoized_property
    is clamping down on closure-based references to 
    Address
    objects, which in turn reference 
    LegacyBuildGraph
    etc
1...145146147...906Latest