https://pantsbuild.org/ logo
Powered by
#development
  • r

    rough-minister-58256

    08/12/2016, 10:49 PM
    totally
  • r

    rough-minister-58256

    08/12/2016, 10:49 PM
    beats leaving a note like “please submit when you get a chance” then another RT to the person to mark submitted
  • b

    billowy-beach-68498

    08/12/2016, 11:03 PM
    @witty-crayon-22786: yeah, I was on my way home. Thanks!
  • w

    witty-crayon-22786

    08/13/2016, 1:19 AM
    hm. don't want to get too tied to pickle, but https://docs.python.org/3.1/library/pickle.html#persistence-of-external-objects is interesting.
  • w

    witty-crayon-22786

    08/13/2016, 1:21 AM
  • r

    rough-minister-58256

    08/13/2016, 1:25 AM
    interesting
  • r

    rough-minister-58256

    08/14/2016, 4:53 AM
    these seem to be our hottest paths for mem allocation:
  • r

    rough-minister-58256

    08/14/2016, 4:53 AM
    Copy code
    #1: <string>:10: 1284483.65332 KB
#2: engine/scheduler.py:588: 1090292.65625 KB
#3: engine/scheduler.py:57: 581957.273438 KB
#4: engine/scheduler.py:269: 581957.046875 KB
#5: engine/scheduler.py:53: 581934.84375 KB
#6: util/memo.py:41: 421362.25 KB
#7: engine/scheduler.py:132: 319049.171875 KB
#8: python2.7/posixpath.py:352: 220569.660156 KB
#9: python2.7/posixpath.py:73: 218943.904297 KB
#10: util/memo.py:102: 199680.0 KB
#11: engine/scheduler.py:592: 110585.25 KB
#12: engine/scheduler.py:153: 75772.0 KB
#13: engine/addressable.py:210: 68393.25 KB
#14: engine/nodes.py:484: 65301.796875 KB
#15: util/dirutil.py:38: <tel:60847.0703125|60847.0703125> KB
#16: build_graph/address.py:137: <tel:52989.7265625|52989.7265625> KB
#17: engine/scheduler.py:598: 39291.53125 KB
#18: engine/scheduler.py:522: 34860.46875 KB
#19: python2.7/posixpath.py:346: <tel:32446.1835938|32446.1835938> KB
#20: pywatchman/pybser.py:212: <tel:30580.1445312|30580.1445312> KB
3193 other: 613269.419922 KB
total allocated size: 6684567.3017578 KB
  • r

    rough-minister-58256

    08/14/2016, 4:53 AM
    measured from a daemon start to full 
    list ::
  • r

    rough-minister-58256

    08/14/2016, 4:54 AM
    I’m guessing the 
    <string>:10
    is 
    eval
  • r

    rough-minister-58256

    08/14/2016, 9:33 AM
    more detail when grouped by traceback
  • r

    rough-minister-58256

    08/14/2016, 9:33 AM
  • f

    fancy-queen-20734

    08/15/2016, 4:38 PM
    @rough-minister-58256: my guess is that the <string>:10 is from the namedtuple eval
  • f

    fancy-queen-20734

    08/15/2016, 4:39 PM
  • r

    rough-minister-58256

    08/15/2016, 6:01 PM
    ah
  • w

    witty-crayon-22786

    08/15/2016, 6:19 PM
    @fancy-queen-20734: the gist of tracebacks is helpful. some of them are fixed in the runnable branch
  • f

    fancy-queen-20734

    08/15/2016, 6:19 PM
    Yeah, that’s what I was looking at. It’s pretty interesting
  • w

    witty-crayon-22786

    08/15/2016, 6:19 PM
    the memoized StepRequest one in particular
  • w

    witty-crayon-22786

    08/15/2016, 6:20 PM
    ...which is going to hold a dict of deps
  • w

    witty-crayon-22786

    08/15/2016, 6:20 PM
    ...hm. yea, that's bad
  • b

    billowy-beach-68498

    08/15/2016, 8:46 PM
    SelectLiteral(A, B), is it similar to A = B(…)?
  • r

    rough-minister-58256

    08/15/2016, 8:50 PM
    yeh
  • r

    rough-minister-58256

    08/15/2016, 8:51 PM
    tho not 100% sure if thats instantiated each time or just handed a reference to a singular 
    B
  • b

    billowy-beach-68498

    08/15/2016, 8:55 PM
    if B.init require some arguments, then where does it get them? from product graph?
  • r

    rough-minister-58256

    08/15/2016, 8:59 PM
    ah, good point - guessing that means it’s likely just referring to a previously instantiated singular object
  • w

    witty-crayon-22786

    08/15/2016, 9:01 PM
    @billowy-beach-68498: SelectLiteral is a selector that always returns the given argument
  • w

    witty-crayon-22786

    08/15/2016, 9:01 PM
    which must have a type that extends the second argument
  • w

    witty-crayon-22786

    08/15/2016, 9:01 PM
    SelectLiteral(address_mapper, AddressMapper)
  • w

    witty-crayon-22786

    08/15/2016, 9:02 PM
    always returns the 
    address_mapper
    , which we declare extends 
    AddressMapper
  • r

    rough-minister-58256

    08/15/2016, 9:02 PM
    ah
1...139140141...906Latest