https://pantsbuild.org/ logo
Powered by
#development
  • w

    witty-crayon-22786

    05/31/2016, 9:23 PM
    allowing a string there would be... fine. i think that that would mean 
    sources='blah.py'
    would be supported suddenly.
  • w

    witty-crayon-22786

    05/31/2016, 9:24 PM
    not a fan of how much is stringly typed though. hopefully we can change the syntax to wrap these all in objects when we decide to improve the BUILD semantics
  • b

    billowy-beach-68498

    05/31/2016, 9:25 PM
    if exclude=‘blah.py’ that means from_sources_field is working on each character of that string?
  • b

    billowy-beach-68498

    05/31/2016, 9:26 PM
    since raw_excludes is a string now?
  • w

    witty-crayon-22786

    05/31/2016, 9:27 PM
    @billowy-beach-68498: mm, yea. should ban that as well.
  • r

    rough-minister-58256

    05/31/2016, 9:27 PM
    from_sources_field currently throws AssertionError on string type
  • w

    witty-crayon-22786

    05/31/2016, 9:27 PM
    yea. that's where the error is coming from.
  • w

    witty-crayon-22786

    05/31/2016, 9:28 PM
    so... would need to change those together.
  • w

    witty-crayon-22786

    05/31/2016, 9:29 PM
  • w

    witty-crayon-22786

    05/31/2016, 9:30 PM
    the syntax we came up with during the experiments was:
    Copy code
    target(name='x', configuration=[python(files=['blah.py'])])
  • b

    billowy-beach-68498

    05/31/2016, 9:36 PM
    the quoted line looks pretty clear.
  • r

    rough-minister-58256

    05/31/2016, 9:45 PM
    https://github.com/pantsbuild/pants/pull/3534/commits/3f1efda940653d47c6b5a33d7bd95f21a9eed0c1 seems to fix both the case of 
    exclude=[‘blah’]
    and 
    exclude=[set([‘blah’])]
    in source
  • r

    rough-minister-58256

    05/31/2016, 9:47 PM
    seems like maybe we should massage the exception handling here too - a smaller variant of the larger paste
  • r

    rough-minister-58256

    05/31/2016, 9:47 PM
    Copy code
    Exception message: Build graph construction failed for DescendantAddresses(directory='3rdparty'):
  Throw(exc=MappingError(u"Failed to parse 3rdparty/jvm/org/apache/curator/BUILD:\nglobal name 'CURATOR_REV' is not defined",))
    Throw(exc=MappingError(u"Failed to parse 3rdparty/jvm/org/apache/curator/BUILD:\nglobal name 'CURATOR_REV' is not defined",))
      Throw(exc=MappingError(u"Failed to parse 3rdparty/python/twitter/common/BUILD:\nglobal name 'COMMONS_VERSION' is not defined",))
      Throw(exc=MappingError(u"Failed to parse 3rdparty/jvm/org/apache/curator/BUILD:\nglobal name 'CURATOR_REV' is not defined",))
  • r

    rough-minister-58256

    05/31/2016, 9:47 PM
    would be ideal at a minimum to optimally format and dedupe there
  • r

    rough-minister-58256

    05/31/2016, 9:48 PM
    not sure where the indention levels are coming from either
  • w

    witty-crayon-22786

    05/31/2016, 9:53 PM
  • r

    rough-minister-58256

    05/31/2016, 9:53 PM
    ah makes sense
  • w

    witty-crayon-22786

    05/31/2016, 9:54 PM
    but, yea... it should be a path.
  • w

    witty-crayon-22786

    05/31/2016, 9:54 PM
    the issue is that because we don't fail fast there, there are a lot of failed paths
  • w

    witty-crayon-22786

    05/31/2016, 9:55 PM
    re previous commit; should be good
  • r

    rough-minister-58256

    05/31/2016, 9:55 PM
    yeah, and I think we want to surface those for sure - prob just makes sense to dedupe etc
  • r

    rough-minister-58256

    05/31/2016, 10:36 PM
  • r

    rough-minister-58256

    05/31/2016, 10:37 PM
    (couldnt add you to the RB directly)
  • b

    billowy-beach-68498

    05/31/2016, 10:40 PM
    ah, thanks
  • r

    rough-minister-58256

    05/31/2016, 11:08 PM
    apparently https://cgit.twitter.biz/source/tree/tweetypie/server/BUILD#n63 is a supported/common pattern? I wonder if it’d make sense to formalize a 
    remapped_bundle
    target to internalize some of these exposed guts.
  • r

    rough-minister-58256

    05/31/2016, 11:10 PM
    or for now I guess just support conversion of 
    Fileset
    to 
    Files
    in 
    from_sources_field
  • w

    witty-crayon-22786

    05/31/2016, 11:11 PM
    @rough-minister-58256: that would break change detection
  • r

    rough-minister-58256

    05/31/2016, 11:12 PM
    which
  • r

    rough-minister-58256

    06/01/2016, 5:58 PM
1...99100101...906Latest