https://pantsbuild.org/ logo
Powered by
#announce
  • e

    enough-analyst-54434

    03/06/2018, 7:59 PM
    FYI: Thrifty dist fix requires a 1.4.0rc4 https://github.com/pantsbuild/pants/pull/5562
  • w

    witty-crayon-22786

    03/06/2018, 11:08 PM
    thanks
  • w

    witty-crayon-22786

    03/06/2018, 11:08 PM
    ... i'm considering cheating and doing it as part of final. ... thoughts on that?
  • e

    enough-analyst-54434

    03/06/2018, 11:16 PM
    Not super-positive. Afaict it was already cheating to add a whole new feature.
  • w

    witty-crayon-22786

    03/06/2018, 11:19 PM
    yea. i figured "new contrib module" is less risky.
  • w

    witty-crayon-22786

    03/06/2018, 11:19 PM
    alright, will cut another rc.
  • g

    gifted-autumn-88099

    03/06/2018, 11:39 PM
    Sorry for the hassle having to make another RC
  • w

    witty-crayon-22786

    03/07/2018, 1:12 AM
  • g

    gifted-autumn-88099

    03/07/2018, 4:14 PM
    I tested 
    1.4.0rc4
    and am confirming the 
    thrifty
    plugin works. Thanks all for helping out with this change, especially @witty-crayon-22786 for the thoughtful review!
  • w

    witty-crayon-22786

    03/07/2018, 8:28 PM
  • w

    witty-crayon-22786

    03/07/2018, 8:28 PM
    guess what! we're going to have another rc yay!
  • w

    witty-crayon-22786

    03/07/2018, 8:29 PM
    and i say that somewhat un-ironically because this is a pretty awesome patch. thanks @rough-minister-58256
  • w

    witty-crayon-22786

    03/07/2018, 8:41 PM
    if it were almost anything else i'd wait for 
    1.4.1
    for it, but this would have been a pretty huge regression vs 
    1.3.0
  • w

    witty-crayon-22786

    03/08/2018, 8:58 PM
    it looks like master is broken, likely due to an upstream packaging change. https://travis-ci.org/pantsbuild/pants/jobs/350824346
  • w

    witty-crayon-22786

    03/08/2018, 9:03 PM
    ...actually, going to wipe caches and then try again before diving into investigation.
  • w

    witty-crayon-22786

    03/08/2018, 9:11 PM
    re-running the most recent failure with a clean cache.
  • w

    witty-crayon-22786

    03/08/2018, 9:15 PM
  • r

    rough-minister-58256

    03/08/2018, 9:19 PM
    Copy code
    Exception message: Package WheelPackage('file:///home/travis/.cache/pants/python_cache/requirements/CPython-2.7.6/attrs-17.4.0-py2.py3-none-any.whl') is not translateable by ChainedTranslator(WheelTranslator, EggTranslator, SourceTranslator)
  • r

    rough-minister-58256

    03/08/2018, 9:19 PM
    the 
    CPython-2.7.6
    might point to an interpreter selection regression here against an old cache path?
  • r

    rough-minister-58256

    03/08/2018, 9:20 PM
    would expect us to be using 2.7.13 in travis, but haven’t looked closely
  • w

    witty-crayon-22786

    03/08/2018, 9:22 PM
    possible
  • r

    rough-minister-58256

    03/08/2018, 9:29 PM
    I know John/Chris were working on some interpreter selection stuff recently, so maybe the cache purge alone will be effective
  • w

    witty-crayon-22786

    03/08/2018, 10:05 PM
    mm.. seems to be making progress now? https://travis-ci.org/pantsbuild/pants/jobs/350824346
  • w

    witty-crayon-22786

    03/08/2018, 10:13 PM
    restarted the last few to try and clean that up.
  • w

    wide-energy-11069

    03/09/2018, 12:16 AM
    the first test ran in the job was with 2.7.6…
  • w

    wide-energy-11069

    03/09/2018, 12:16 AM
    Copy code
    Invalidated 76 targets.
23:47:50 00:05     [pytest]
                   Invalidated 1 target.
23:47:50 00:05       [run]
                     ============== test session starts ===============
                     platform linux2 -- Python 2.7.6, pytest-3.4.2, py-1.5.2, pluggy-0.6.0 -- /usr/bin/python2.7
                     cachedir: .pants.d/.pytest_cache
                     rootdir: /home/travis/build/pantsbuild/pants/.pants.d, inifile: /home/travis/build/pantsbuild/pants/.pants.d/test/pytest-prep/CPython-2.7.6/2b8b3f0243aa863677059bdcbabc9fcbdf452ad1/pytest.ini
                     plugins: timeout-1.2.1, cov-2.4.0
                     collecting ... collected 8 items
  • w

    wide-energy-11069

    03/09/2018, 12:16 AM
  • w

    wide-energy-11069

    03/09/2018, 12:29 AM
    and same for the rest
  • w

    wide-energy-11069

    03/09/2018, 12:41 AM
    it’s been like that for a while, so need to backtrace where it started
  • w

    wide-energy-11069

    03/09/2018, 10:43 PM
    ah I’m the releaser today
1...828384...206Latest