pantsbuild #announce

but... sheesh. that whole cluster of issues is a case in point for using one or both of 1) codegen'd structs for RPC, 2) type checking in your language

witty-crayon-22786

02/25/2018, 6:40 PM

for example: the

cloc

issue. probably won't be possible once we get mypy in place? cc @fast-nail-55400

fast-nail-55400

02/25/2018, 10:16 PM

What’s the

cloc

issue? Not sure I have the context

witty-crayon-22786

02/25/2018, 10:17 PM

https://github.com/pantsbuild/pants/pull/5239#issuecomment-368322063

witty-crayon-22786

02/25/2018, 10:17 PM

just a vanilla undefined reference issue

happy-kitchen-89482

02/26/2018, 1:35 AM

I only noticed it because IntelliJ marked it

happy-kitchen-89482

02/26/2018, 1:35 AM

So clearly it’s possible to detect even without annotations

witty-crayon-22786

02/26/2018, 3:32 AM

not in the pypa case..., but yes with cloc

wide-energy-11069

03/02/2018, 6:27 PM

@witty-crayon-22786 should change log for 1.5.0rc0 be the diff from 1.4.0rc0 or 1.5.0.dev0?

wide-energy-11069

03/02/2018, 6:28 PM

i’ll clarify that in the doc

wide-energy-11069

03/02/2018, 6:36 PM

ah looking at https://www.pantsbuild.org/notes-1.4.x.html. it would be the diff between master and last 1.4.0.dev commit

average-vr-56795

03/02/2018, 7:54 PM

Was there no release at all last week?

average-vr-56795

03/02/2018, 7:55 PM

Oh, no, there was, just got confused because there was also a 1.4.0rc2 🙂

wide-energy-11069

03/02/2018, 8:00 PM

https://github.com/pantsbuild/pants/pull/5536

average-vr-56795

03/02/2018, 11:13 PM

I’ve pushed release binaries to pypi but for some reason can’t fetch them. It’s pretty late, so I’m going to debug on Monday, unless anyone else wants to take a look first

wide-energy-11069

03/02/2018, 11:21 PM

there’s a lag i think

wide-energy-11069

03/02/2018, 11:21 PM

for cached content

wide-energy-11069

03/02/2018, 11:22 PM

@average-vr-56795 seeing it now. thanks

average-vr-56795

03/02/2018, 11:29 PM

I see it in pypi but release.sh -t fails

witty-crayon-22786

03/05/2018, 9:17 PM

https://github.com/pantsbuild/pants/pull/5545

witty-crayon-22786

03/05/2018, 9:17 PM

see comment: sorry.

witty-crayon-22786

03/06/2018, 12:22 AM

aaaand one more: https://github.com/pantsbuild/pants/pull/5549

wide-energy-11069

03/06/2018, 7:13 PM

1.5.0rc0 https://github.com/pantsbuild/pants/pull/5536

rough-minister-58256

03/06/2018, 7:53 PM

@wide-energy-11069 any chance we can sneak https://github.com/pantsbuild/pants/pull/5550 into 1.5.0rc0?

wide-energy-11069

03/06/2018, 7:55 PM

@rough-minister-58256 sure just land it and i’ll update rc0 PR

rough-minister-58256

03/06/2018, 7:55 PM

sweet, thanks!