https://pantsbuild.org/ logo
Powered by
#announce
  • w

    witty-crayon-22786

    11/11/2017, 1:10 AM
    ...oh, whoops. forgot about that.
  • w

    witty-crayon-22786

    11/11/2017, 1:12 AM
    @enough-analyst-54434: that would be much appreciated.
  • e

    enough-analyst-54434

    11/11/2017, 1:12 AM
    Cool
  • e

    enough-analyst-54434

    11/11/2017, 1:41 AM
  • w

    witty-crayon-22786

    11/11/2017, 6:19 AM
    thanks!
  • e

    enough-analyst-54434

    11/11/2017, 11:32 PM
  • e

    enough-analyst-54434

    11/11/2017, 11:47 PM
    Going to release 1.3.1.rc1 now which Stu has fully prepared with release notes and version change and just not the actual release push.
  • e

    enough-analyst-54434

    11/12/2017, 12:34 AM
  • w

    wide-energy-11069

    11/17/2017, 5:27 PM
    hi i’m doing the release today
    👋 1
  • w

    wide-energy-11069

    11/17/2017, 10:36 PM
  • w

    witty-crayon-22786

    11/20/2017, 10:19 PM
    sooo, it looks like i need the ability to programmatically set the pants version for https://github.com/pantsbuild/pants/issues/4896#issuecomment-345105324 ... i thought i could sneak around it by having the internal version generate differently suffixed whls without actually mutating 
    ./src/python/pants/version.py
    , and that results in properly versioned whls, but 
    ./pants --version
    continues to report the hardcoded version because it doesn't care what the whl version was.
  • w

    witty-crayon-22786

    11/20/2017, 10:22 PM
    in theory we could add a 
    --set-pants-version-suffix-this-probably-is-not-what-you-want=+1234
    flag to core, and have that directly affect 
    VERSION
    ... but that feels a bit groady.
  • w

    witty-crayon-22786

    11/20/2017, 10:23 PM
    (...and would probably introduce some weird bootstrapping issues.)
  • w

    witty-crayon-22786

    11/20/2017, 10:24 PM
    or i could do what we do internally and literally 
    sed
    the suffix into 
    ./src/python/pants/version.py
    temporarily.
  • w

    witty-crayon-22786

    11/20/2017, 10:26 PM
    maybe there is a resource-centric way that would make it less awkward? ie, load the actual version string from a resource to allow for 
    echo $VERSION > $FILE
    rather than 
    sed
    ?
  • w

    witty-crayon-22786

    11/20/2017, 10:26 PM
    cc @rough-minister-58256: in case you have thoughts ^
  • r

    rough-minister-58256

    11/20/2017, 10:28 PM
    well
  • r

    rough-minister-58256

    11/20/2017, 10:29 PM
    we wouldnt strictly need the 
    --set-pants-version-suffix-this-probably-is-not-what-you-want=+1234
    bit
  • r

    rough-minister-58256

    11/20/2017, 10:29 PM
    we could just add another arbitrary bootstrap option for the ‘source fingerprint’
  • r

    rough-minister-58256

    11/20/2017, 10:29 PM
    and it’d be sufficient for pantsd options invalidation
  • w

    witty-crayon-22786

    11/20/2017, 10:30 PM
    i think the version is needed even earlier than bootstrap options... but maybe not...?
  • r

    rough-minister-58256

    11/20/2017, 10:30 PM
    not for pantsd at least
  • r

    rough-minister-58256

    11/20/2017, 10:31 PM
    the only reason it occured to me to use/override version was because its a bootstrap option
  • w

    witty-crayon-22786

    11/20/2017, 10:31 PM
    @rough-minister-58256: oh, that doesn't work though. because this is only for pantsbuild/pants
  • r

    rough-minister-58256

    11/20/2017, 10:31 PM
    yeah, itd be something we’d use strictly for dev mode on pants
  • r

    rough-minister-58256

    11/20/2017, 10:31 PM
    but that doesnt solve the sed problem
  • r

    rough-minister-58256

    11/20/2017, 10:31 PM
    what if we overrode version.py to read env vars?
  • r

    rough-minister-58256

    11/20/2017, 10:31 PM
    too gross?
  • r

    rough-minister-58256

    11/20/2017, 10:32 PM
    then when you needed a wheel of 
    pants-1.0.0+<sha>
    you’d just PANTS_VERSION_OVERRIDE=x ./pants setup-py etc
  • w

    witty-crayon-22786

    11/20/2017, 10:32 PM
    heh. pretty gross. and i think it has the effect of still allowing users to affect the pants version
1...676869...206Latest