https://pantsbuild.org/ logo
Powered by
#announce
  • r

    rough-minister-58256

    01/06/2017, 7:01 PM
    it’s stored in the pants’ calendar iirc
  • r

    rough-minister-58256

    01/06/2017, 7:02 PM
  • w

    wide-energy-11069

    01/06/2017, 7:02 PM
    Calendar Error
  • r

    rough-minister-58256

    01/06/2017, 7:03 PM
    hrm
  • r

    rough-minister-58256

    01/06/2017, 7:03 PM
  • r

    rough-minister-58256

    01/06/2017, 7:03 PM
    wonder if you can just add by ID somehow?
  • w

    wide-energy-11069

    01/06/2017, 7:04 PM
    You do not have access to Pants's calendar
  • r

    rough-minister-58256

    01/06/2017, 7:04 PM
    ah may be a permissions thing
  • w

    witty-crayon-22786

    01/06/2017, 7:14 PM
    @ancient-stone-50795 : how is that calendar set up?
  • w

    witty-crayon-22786

    01/06/2017, 7:14 PM
    maybe we can migrate it to the pantsbuild@gmail.com account
  • l

    limited-country-20626

    01/06/2017, 10:02 PM
    going to start the 1.30 dev release. Will punt on the rc since I don't think there are any backports ready.
  • w

    witty-crayon-22786

    01/06/2017, 10:03 PM
    yea, that's fine. i'm probably going to release 1.2.1 as is based on the last rc
  • w

    witty-crayon-22786

    01/06/2017, 10:03 PM
    ...at some point.
  • a

    ancient-stone-50795

    01/09/2017, 4:04 PM
    1.2.1 sounds good to me. I've looked at the pants calendar and it says that I have permission to make changes but I can't see much else
  • a

    ancient-stone-50795

    01/09/2017, 4:05 PM
    @User uploaded a file:

    Screen Shot 2017-01-09 at 11.03.19 AM.png▾

  • b

    busy-bird-27454

    01/10/2017, 3:05 PM
    @busy-bird-27454 has left the channel
  • h

    happy-kitchen-89482

    01/13/2017, 12:32 AM
    Hi all, I've got the weekly release tomorrow
  • h

    happy-kitchen-89482

    01/13/2017, 12:32 AM
    Any comments/things I should know?
  • w

    witty-crayon-22786

    01/13/2017, 1:46 AM
    @happy-kitchen-89482 : don't think so... @billowy-beach-68498 is currently running an internal release, so he might have additional feedback
  • h

    happy-kitchen-89482

    01/13/2017, 1:51 AM
    Presumably just 1.3.0dev7, right? I don't think we're ready for a 1.3.0 rc?
  • w

    witty-crayon-22786

    01/13/2017, 1:54 AM
    yea, not yet
  • w

    witty-crayon-22786

    01/13/2017, 1:54 AM
    i'll likely get 
    1.2.1
    out next week
  • b

    billowy-beach-68498

    01/13/2017, 6:01 PM
    @happy-kitchen-89482 When testing internally, I have seen a few targets failed with message like "unhashable instance". Looks like some python classes generated from thrift file are not hashable. I am looking into this, but wonder whether you have some thoughts on it.
  • b

    billowy-beach-68498

    01/13/2017, 6:05 PM
    hmm, prior to the refactor, "gen" goal does not generate python file for python_thrift_library?
  • b

    billowy-beach-68498

    01/13/2017, 7:11 PM
    I found that in python files generated in current pants, classes are old style (not inherit from object), but prior to https://github.com/pantsbuild/pants/commit/e01cee8959da269c0b526138760847901e4d4a48, classes in generated python files are new style. Maybe that caused the "unhashable instance" error?
  • b

    billowy-beach-68498

    01/13/2017, 7:40 PM
    I have verified that this new/old style difference is the cause of "unhashable instance" error. Now the question is how is this difference introduced?
  • h

    happy-kitchen-89482

    01/13/2017, 7:44 PM
    Yes, gen goal did nothing for python previously
  • h

    happy-kitchen-89482

    01/13/2017, 7:44 PM
    so presumably that's just a missing flag telling thrift to generate new style classes
  • h

    happy-kitchen-89482

    01/13/2017, 7:44 PM
    easy fix
  • b

    billowy-beach-68498

    01/13/2017, 8:19 PM
1...293031...206Latest