Ergonomic, hermetic, user-friendly software build system for Python, Go, Java, Kotlin, Protobuf, Scala, Shell. Pants lets you fearlessly scale up your codebase!

Pants

but I will send up the cache_manager changes as a followup

I think the test is just off, it takes a target that should be valid and marks it dirty

<@U0607UFLH> : thanks... sorry for that test.

sure, thanks for the confirm...I have been half digging as I do my day. I am adding some additional coverage to protect my changes, but the new code in src is all done

If you need, I can also probably pick up putting out the release, I know this went a little long

no, that's ok... as soon as this lands i'm happy to do it.

is this note in jvm_compile still true?

<https://github.com/pantsbuild/pants/blob/master/src/python/pants/backend/jvm/tasks/jvm_compile/zinc/zinc_compile.py#L182>

The 1.2.x branch had some github issues referenced that looked in varying states of resolution:

ha, okay, thanks. Just writing some test cases and trying to derive what needs to be protected

reading the sbt github issues was... illuminating :face_with_rolling_eyes:

turning off incremental caching by default was probably the single largest "quality" improvement we've seen, because it almost entirely eliminated bad cache artifacts

(to keep the cache hit rate high, we also use `--no-compile-zinc-incremental` in CI)

Planning on landing this AM: <https://github.com/pantsbuild/pants/pull/4139>

ah - I just got in and saw y.ic's review - will respond and update. Thanks!

alright, finally in. Thanks for waiting on it

<@U0607UFLH> : thanks mateo. if i were to get an rc out today, would you have time to test it? or should we wait till the new year at this point

although I don't know that we would need to rush out the stable until later

we have really been struggling to get a 1.2.x we can consume'

and it is blocking the docker_plugin and more.