https://pantsbuild.org/ logo
Powered by
#announce
  • w

    witty-crayon-22786

    11/16/2016, 6:47 PM
    awesome!
  • e

    enough-analyst-54434

    11/16/2016, 6:55 PM
    K - release prep is out: https://rbcommons.com/s/twitter/r/4383/ I don't think I'll attempt to do the release in SLC but instead wait until I'm home with a solid internet connection - so .. ~8pm Mountain this should be all done.
  • e

    enough-analyst-54434

    11/16/2016, 9:47 PM
    1.3.0dev1 is released - long live the native engine!: https://groups.google.com/d/topic/pants-devel/VsSsCXtQWqU/discussion
    coke 3
    enginerefactor 2
    🎉 2
  • w

    witty-crayon-22786

    11/16/2016, 9:48 PM
    huzzah!
  • w

    witty-crayon-22786

    11/16/2016, 9:48 PM
    thanks a ton.
  • e

    enough-analyst-54434

    11/16/2016, 9:50 PM
    NP - happy to help push the ball forward on this stuff
  • l

    limited-country-20626

    11/18/2016, 9:56 PM
    going to start on creating the release in a bit. Let me know if you have something you want to land.
  • l

    limited-country-20626

    11/18/2016, 10:31 PM
    I used github to land a pull request. I thought that the "Squash and merge" workflow had a bug in it, but I guess github just surfaces some privacy options I was unaware of.
    Copy code
    commit 983a48e2ec1bc68c8d6322b70dfd83e0cc48c334
Author: Mark Davis <markdav@users.noreply.github.com>
Date:   Fri Nov 11 15:26:35 2016 +0000

    Spelling mistake in first_tutorial
  • l

    limited-country-20626

    11/18/2016, 10:32 PM
    that is from cloning his fork. The one landed through the github UI looks similar enough:
    Copy code
    commit 3d70ca5d71c17727115ad3cec62beb71bd453f3c
Author: Mark Davis <markdav@users.noreply.github.com>
Date:   Fri Nov 18 21:55:27 2016 +0000

    Spelling mistake in first_tutorial (#4045)
  • l

    limited-country-20626

    11/19/2016, 12:54 AM
    A release that appears ready to go is up at: https://github.com/pantsbuild/pants/pull/4080 There was a whitespace error in the markdown though, and it looks like it'll be awhile yet before it gets through travis. I am going to get on the train - if I get enough Shipits through RB or github, I will push the release later tonight.
  • w

    witty-crayon-22786

    11/19/2016, 12:57 AM
    @limited-country-20626 : just updated the "how to contribute" docs... make sure to use the 
    reviewable
    label
  • l

    limited-country-20626

    11/19/2016, 12:58 AM
    Ah, thanks. Will add.
  • l

    limited-country-20626

    11/19/2016, 12:58 AM
    I actually posted through RB
  • w

    witty-crayon-22786

    11/19/2016, 12:58 AM
    thanks!
  • l

    limited-country-20626

    11/19/2016, 12:58 AM
    But then I got concerned it would wither now!
  • w

    witty-crayon-22786

    11/19/2016, 12:59 AM
    #shipit
  • w

    witty-crayon-22786

    11/19/2016, 8:18 PM
    hm... crap. apparently need to manually use the PR description as the message. i should have noticed that.
  • w

    wide-energy-11069

    11/19/2016, 8:24 PM
    at least the commit message links to the PR.
  • w

    witty-crayon-22786

    11/19/2016, 8:28 PM
    yea.
  • l

    limited-country-20626

    11/20/2016, 6:35 AM
    was kind of waiting for another shipit https://github.com/pantsbuild/pants/pull/4080 but I am going to go forward with the release in the AM. I updated the pull to include the two new commits from saturday.
  • l

    limited-country-20626

    11/20/2016, 11:36 PM
    @User uploaded a file:

    Screen Shot 2016-11-20 at 6.35.33 PM.pngâ–¾

    and commented: I got behind this AM, but I am finishing up the release now, since I got the next shipit. There are two competing github workflows, 1) the Squash and Merge button 2) push from clone I think I prefer (1), since it attaches the pull request to the commit. But that will make every commit message permanently freight the pull request number.
  • l

    limited-country-20626

    11/20/2016, 11:51 PM
    b.enjy's last commit failed the CI but passed once I restarted the shard. The release is in the CI and will push once it goes green
  • e

    enough-analyst-54434

    11/21/2016, 12:21 AM
    @limited-country-20626 this needs to go in before you release or else no appropriate OSX native engine binary will be available: https://github.com/pantsbuild/pants/pull/4086
  • e

    enough-analyst-54434

    11/21/2016, 12:21 AM
    Added you as a reviewer
  • e

    enough-analyst-54434

    11/21/2016, 12:22 AM
    Feel free to click squash and merge if it looks good to you.
  • e

    enough-analyst-54434

    11/21/2016, 12:23 AM
    I'll be afk for about the next 3 hours
  • l

    limited-country-20626

    11/21/2016, 12:37 AM
    Okay, thanks for the heads up. Will look in a bit
  • l

    limited-country-20626

    11/21/2016, 2:26 AM
    merging
  • e

    enough-analyst-54434

    11/21/2016, 4:25 AM
    Thanks @limited-country-20626, that did the trick once it hit master and published the native engine binary for OSX making pants releasing good to go.
  • l

    limited-country-20626

    11/21/2016, 4:36 AM
    great. 1.3.0dev2 is now also live, writing to pants-devel right now
1...222324...206Latest