pantsbuild #announce

Channels

welcome

github-notifications

development

witty-crayon-22786

10/30/2020, 11:09 PM

which would be rc0

witty-crayon-22786

10/30/2020, 11:09 PM

Copy code

* commit 969c8dcba6eda0c939918b3bc5157ca45099b4d1 (tag: release_2.0.0rc0)
| Author: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
| Date:   Sun Oct 11 21:38:01 2020 -0700

witty-crayon-22786

10/30/2020, 11:10 PM

you can also (maybe?) use

…

rather than

..

(three vs two) to get the right thing out of git log.

witty-crayon-22786

10/30/2020, 11:11 PM

but yea… you want to diff against the relevant commit on master rather than in a branch.

hundreds-breakfast-49010

10/30/2020, 11:15 PM

if I run

./build-support/bin/contributors.sh -s release_2.0.0

on master, I get a very large number of commits

witty-crayon-22786

10/30/2020, 11:16 PM

yes. do not do that. that is the wrong command.

hundreds-breakfast-49010

10/30/2020, 11:16 PM

I only want commits after

Copy code

commit d7f8f29fca019058666243552f439c7a09d6cdd4                                                                                                                                                                      
Author: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
Date:   Mon Oct 26 17:53:56 2020 -0700                                                                                                                                                                               
                                                                                                                                                                                                                     
    Prepare 2.0.0 (#11053)

I think

witty-crayon-22786

10/30/2020, 11:16 PM

diff against rc0, which was the last commit on master.

hundreds-breakfast-49010

10/30/2020, 11:16 PM

./build-support/bin/contributors.sh -s release_2.0.0rc0

has exactly the same output

witty-crayon-22786

10/30/2020, 11:16 PM

release_2.0.0

is a tag on the 2.0.x branch, which isn’t what you want.

witty-crayon-22786

10/30/2020, 11:17 PM

@hundreds-breakfast-49010:

./build-support/bin/contributors.sh -s release_2.0.0rc0

is the correct output, afaict.

hundreds-breakfast-49010

10/30/2020, 11:17 PM

that is also showing commits since early october

witty-crayon-22786

10/30/2020, 11:18 PM

it should… rc0 was cut on Oct 11th

witty-crayon-22786

10/30/2020, 11:19 PM

so yea, i think that this is a red herring.

Copy code

./build-support/bin/contributors.sh -s release_2.0.0

has the right output, as does

Copy code

git log release_2.0.0..HEAD

witty-crayon-22786

10/30/2020, 11:19 PM

@hundreds-breakfast-49010: there just hasn’t been another release from master in that long.

witty-crayon-22786

10/30/2020, 11:20 PM

so that is the accurate set of commits.

hundreds-breakfast-49010

10/30/2020, 11:20 PM

ah, okay

hundreds-breakfast-49010

10/30/2020, 11:21 PM

so then I ran the changelog commit wrong, and I'm leaving out a bunch of commits after we cut rc0. although that would include a lot of cherrypicks

witty-crayon-22786

10/30/2020, 11:21 PM

(and i was wrong about needing to diff against

rc0

: two dots (

..

) does the right thing in that case: three (

…

) does the wrong thing.)

witty-crayon-22786

10/30/2020, 11:21 PM

yea, it should include the originals of all of the stuff that was cherry-picked.

hundreds-breakfast-49010

10/30/2020, 11:39 PM

updated https://github.com/pantsbuild/pants/pull/11089

witty-crayon-22786

10/30/2020, 11:42 PM

🚢

👍 1

hundreds-breakfast-49010

10/30/2020, 11:52 PM

this is on my mind because of the release today - I wonder how hard it would be to switch the release notes to markdown

💯 1

hundreds-breakfast-49010

10/30/2020, 11:52 PM

the rst format seems a little fiddly

witty-crayon-22786

10/31/2020, 12:16 AM

shouldn’t be bad. wheels rendered on PyPI support either, and that’s the only place we use it now (…that and linking to the file in github, which is fine with either)

👍 1

hundreds-breakfast-49010

10/31/2020, 4:53 AM

2.1.0.dev0 is released: https://pypi.org/project/pantsbuild.pants/2.1.0.dev0/

❤️ 1

hundreds-father-404

11/06/2020, 3:38 PM

Thoughts on today being 2.1.0rc0? 2.1.0.dev0 was unusually big and represented multiple weeks worth of development. (Also I’d love to have 2.1 stable release by next week for the new blog post on Py3 migrations)

hundreds-breakfast-49010

11/06/2020, 5:47 PM

why not?

hundreds-father-404

11/09/2020, 7:33 PM

With Mac Silicon coming out very soon..it’s even more important we start building Pants for more platforms than x86. One challenge is that we release Pants as a py36, py37, and py38 wheel. We already build 6 wheels, and any new platform means 3 more wheels. One solution is for us to switch to “rust embeds python” (https://github.com/pantsbuild/pants/issues/7369). In the meantime, thoughts on requiring Py37 or Py38 to run Pants? Dropping Py36.

jolly-midnight-72759

11/10/2020, 6:24 PM

The topic for this channel leads to a 404. https://www.pantsbuild.org/docs/releases does not look like the right replacement. Maybe https://www.pantsbuild.org/docs/versions is a good replacement.