pantsbuild #announce

Channels

welcome

github-notifications

development

hundreds-father-404

05/26/2020, 11:29 PM

https://github.com/pantsbuild/pants/pull/9872

hundreds-father-404

05/27/2020, 12:04 AM

I’m logging off for the day for Brian’s dad’s memorial. Could someone please merge this when green? Cc @hundreds-breakfast-49010 @witty-crayon-22786

hundreds-breakfast-49010

05/27/2020, 12:06 AM

@hundreds-father-404 sure

hundreds-father-404

05/27/2020, 12:13 AM

thank you

hundreds-father-404

05/27/2020, 12:57 AM

Ended up leaving late. Just merged

👍 1

hundreds-father-404

05/27/2020, 4:28 PM

Hello. I’m thinking this Friday should be 1.29.0rc0 to avoid 1.29 from getting too big. The main change we have is Pantsd by default. I also plan to make this be the release where plugin authors need to write Target API bindings. Does this sound okay? (I’ll soon be adding dep inference, and I don’t want that to be in 1.29 because it’ll be too hard to get stable by then. I’m hoping to land dep inference in 1.30)

witty-crayon-22786

05/27/2020, 5:37 PM

yea, that sounds reasonable.

witty-crayon-22786

05/27/2020, 5:37 PM

it will also be dynamic ui by default i think…?

hundreds-father-404

05/27/2020, 5:38 PM

Ah, yes. that’s another important change

witty-crayon-22786

05/28/2020, 5:56 PM

it looks like the ini/toml deprecation is triggering on pantsbuild/pants, which is peculiar

witty-crayon-22786

05/29/2020, 5:14 PM

hey folks! i’m on release duty today. i think the above

rc

file thing should probably get nailed down first regardless, so i won’t be starting it this morning

witty-crayon-22786

05/29/2020, 5:15 PM

but also: are we thinking that this is 1.29.0rc0, or are we expecting to wait for other things?

hundreds-father-404

05/29/2020, 5:17 PM

I think this should be rc0. a) we already have a lot in this release, b) we can drop all the things we deprecated sooner, and c) I’m 1-4 days away from dep inference for first party code, I think, and I don’t want to commit to that being in 1.29

hundreds-father-404

05/29/2020, 5:18 PM

The one thing I’d like to include, if possible, is dropping

abi3

. I’m blocked by a change I’m about to put up to

packages.py

witty-crayon-22786

05/29/2020, 6:11 PM

ok. i’ll adjust the rc file thing.

happy-kitchen-89482

05/29/2020, 6:12 PM

I'd like to squeeze the source root sentinel file change in if I can, when were you planning to cut?

happy-kitchen-89482

05/29/2020, 6:14 PM

And I'd definitely like to get https://github.com/pantsbuild/pants/pull/9888 in (@witty-crayon-22786, if you could give it a final look? thanks)

👀 1

hundreds-father-404

05/29/2020, 6:15 PM

I’m doing the release to free up Stu. I still need to land two infra changes, so probably won’t get to it till after the graduation ceremony around 4

🎓 1

👍 1

happy-kitchen-89482

05/29/2020, 11:03 PM

My change is in, so good to go from my perspective.

❤️ 1

hundreds-father-404

05/30/2020, 1:00 AM

Headed out for a while. If anyone is around in 30ish minutes, I’d appreciate a merge of the release prep 🙂 https://github.com/pantsbuild/pants/pull/9905 (although only once John has merged https://github.com/pantsbuild/pants/pull/9903 first)

hundreds-father-404

05/30/2020, 3:05 PM

Huh. So it looks like we’ve never actually released the

pantsbuild.pants.contrib.buildrefactor

plugin..It’s nowhere on PyPI or in the files

packages.py

and

release_packages.py

, which both control what gets released. Nor has it ever been, according to Git history. But I thought Twitter has used buildozer in the past?

witty-crayon-22786

05/30/2020, 3:32 PM

buildozer works directly as well

hundreds-father-404

05/30/2020, 3:32 PM

Okay. So I think it’s safe to delete the plugin since it’s never been released?

hundreds-father-404

05/30/2020, 3:33 PM

We can add it with a V2 implementation in the future, need be

polite-garden-50641

05/30/2020, 3:49 PM

I think there is a good chance that code coverage is busted in this 1.29.0rc0 release, see https://github.com/pantsbuild/pants/issues/9914

witty-crayon-22786

06/02/2020, 8:17 PM

hey folks! there are a few picks bound for 1.29.x, so there should be another rc soon

witty-crayon-22786

06/02/2020, 8:17 PM

if you have anything you want to pick there, please eagerly do that if you’d like, or alternative mark the PRs

needs-cherrypick

and i can pick some things.

witty-crayon-22786

06/02/2020, 8:18 PM

(i think i will have a majority of picks, so am happy to run the rc)

witty-crayon-22786

06/02/2020, 8:20 PM

https://github.com/pantsbuild/pants/issues?q=label%3Aneeds-cherrypick+

hundreds-father-404

06/02/2020, 10:16 PM

Thank you. We’ll need another rc after this, I think, but would be great to get the current things out