pantsbuild #announce

Channels

welcome

github-notifications

development

hundreds-father-404

01/22/2020, 12:59 AM

Hey has 1.24.0rc1 been stable enough to cut 1.24.0? A user pointed out the most recent stable version is 1.23.0

average-vr-56795

01/22/2020, 11:44 AM

I think @witty-crayon-22786 was going to do that some time this week :)

💯 1

witty-crayon-22786

01/22/2020, 4:36 PM

i was, yea... and then there was another cherry-pick... argh =(

😢 1

witty-crayon-22786

01/22/2020, 4:36 PM

too slow.

witty-crayon-22786

01/23/2020, 8:42 PM

https://github.com/pantsbuild/pants/pull/9005

happy-kitchen-89482

01/28/2020, 6:11 PM

No dev release last week?

hundreds-breakfast-49010

01/29/2020, 11:19 PM

I'm about to do a dev release (my first time doing this!)

🍾 3

hundreds-father-404

01/29/2020, 11:22 PM

Will this be 1.25.0rc0? If so, I think we deprecate

globs

in the 1.26.x series, then. 1.25.0 adds support for the new style, 1.26.0 deprecates

globs

, and possibly 1.28.0 removes

globs

(the aggressive timeline is because we plan to distribute

fix_deprecated_glob_usages.py

so it should be very little work for users to fix things)

hundreds-breakfast-49010

01/29/2020, 11:23 PM

shouldn't this be

1.25.0.rc3

hundreds-breakfast-49010

01/29/2020, 11:23 PM

er, sorry,

1.25.0.dev3

happy-kitchen-89482

01/29/2020, 11:31 PM

I think it would be

1.25.0.dev3

happy-kitchen-89482

01/29/2020, 11:32 PM

It may be time to cut the first rc from 1.25.0 but that's not something Greg should have to worry about on his first release

👍 1

hundreds-father-404

01/29/2020, 11:35 PM

Sounds good!

hundreds-breakfast-49010

01/29/2020, 11:42 PM

https://github.com/pantsbuild/pants/pull/9038

hundreds-breakfast-49010

01/29/2020, 11:48 PM

can anyone ack the PR? <!here>

hundreds-breakfast-49010

01/30/2020, 3:26 AM

release is done,but the documentation on https://www.pantsbuild.org/notes-master.html doesn't seem to have been updated

witty-crayon-22786

01/30/2020, 4:10 AM

the last step of the release process is to upload it... do you see errors there?

witty-crayon-22786

01/30/2020, 4:11 AM

can publish it any time with https://www.pantsbuild.org/docs.html#publishing-the-site

hundreds-breakfast-49010

01/30/2020, 5:46 AM

@witty-crayon-22786 yeah I think the publish_docs script is doing something wrong when it tries to auth to github

hundreds-breakfast-49010

01/30/2020, 5:46 AM

Copy code

Username for '<https://github.com>': gshuflin
Password for '<https://gshuflin>@github.com': 
remote: Invalid username or password.
fatal: Authentication failed for '<https://github.com/pantsbuild/pantsbuild.github.io.git/>'

hundreds-breakfast-49010

01/30/2020, 6:02 AM

you don't usually auth to <username>@github.com, right? it's always git@github.com?

average-vr-56795

01/30/2020, 11:07 AM

@hundreds-breakfast-49010 See https://github.com/pantsbuild/pants/pull/8757

👍 2

hundreds-breakfast-49010

01/30/2020, 6:55 PM

thanks @average-vr-56795 docs are updated now

hundreds-breakfast-49010

01/30/2020, 6:56 PM

sending out the email

hundreds-father-404

01/30/2020, 6:56 PM

Hey could someone add Greg and me to the release calendar please? eric@toolchain.com and greg.shuflin@toolchain.com

aloof-angle-91616

01/30/2020, 6:56 PM

wasn't aware there was a release calendar, nice

hundreds-breakfast-49010

01/30/2020, 6:56 PM

it might be good to have that note about github personal access tokens in the release process documentation

☝️ 2

aloof-angle-91616

01/30/2020, 6:58 PM

this issue with the release script took up a ton of @salmon-summer-38098 and my time one day a while ago. i also accidentally once pushed the docsite to pantsbuild/pants and immediately reverted it in order to obtain many thousands more changed lines than any other contributor

aloof-angle-91616

01/30/2020, 6:58 PM

any thoughts about improvements to the release process are usually good thoughts

happy-kitchen-89482

01/30/2020, 7:23 PM

Thanks for hopping into the rotation, @hundreds-breakfast-49010 and @hundreds-father-404!!

❤️ 1

👖 3