https://pantsbuild.org/ logo
Powered by
#announce
  • l

    limited-country-20626

    11/04/2019, 4:40 AM
    I saw the CI has a sanity check flag, which I did get running
  • l

    limited-country-20626

    11/04/2019, 3:36 PM
    Working on the release some more. The commit is landed but I can't get the wheel shards green. I hit this same set of failures on a recent release, which eric helped me get through.
    h
    • 2
    • 1
  • l

    limited-country-20626

    11/04/2019, 3:37 PM
    There are two failures. The integration tests I understand, that is from https://github.com/pantsbuild/pants/issues/8294
  • a

    aloof-angle-91616

    11/04/2019, 3:38 PM
    checking out the PR
  • l

    limited-country-20626

    11/04/2019, 3:38 PM
    I cannot remember what we did to get the actual wheel shards green though 😐
  • l

    limited-country-20626

    11/04/2019, 3:38 PM
    thanks friends
  • a

    aloof-angle-91616

    11/04/2019, 3:38 PM
    prayer
  • a

    aloof-angle-91616

    11/04/2019, 3:38 PM
    thanks for working through this!
  • l

    limited-country-20626

    11/04/2019, 3:40 PM
    The failure that blocks this is the
  • l

    limited-country-20626

    11/04/2019, 3:40 PM
    Copy code
    Creating setup.py project for PythonLibrary(BuildFileAddress(contrib/python/src/python/pants/contrib/python/checks/checker/BUILD, checker))
15:31:43 00:03       [find-namespace-packages]
                   Running bdist_wheel --universal against /travis/workdir/dist/pantsbuild.pants.contrib.python.checks.checker-1.23.0dev0+gitd21e376c
               Waiting for background workers to finish.
15:31:44 00:04   [complete]
               SUCCESS
cp: cannot stat `': No such file or directory
Failed to find package pantsbuild.pants-1.23.0dev0+gitd21e376c!
Dry run release failed.
The command "docker run
  • l

    limited-country-20626

    11/04/2019, 3:42 PM
    we were eventually able to get this green last time, although I think maybe the cache on GCP was wiped which I don't have access to
  • l

    limited-country-20626

    11/04/2019, 3:42 PM
    not sure that is actually involved, tbh
  • l

    limited-country-20626

    11/04/2019, 3:42 PM
  • a

    aloof-angle-91616

    11/04/2019, 3:43 PM
    i might try maybe editing the travis yml generator to run pants with 
    -ldebug
    here? i'm not sure that would necessarily provide any further info
  • a

    aloof-angle-91616

    11/04/2019, 3:43 PM
    and perhaps checking the contents of 
    dist/
    with another 
    ls
    or something that runs before we try to 
    cp
    anything to see if it's there but named weirdly, or if the glob we're using is wrong
  • a

    aloof-angle-91616

    11/04/2019, 3:44 PM
    i would also maybe convert that 
    cp
    into a 
    cp -v
    , which will likely produce the same error but hopefully describe what the destination file is supposed to be (which may not be useful info)
  • a

    aloof-angle-91616

    11/04/2019, 3:46 PM
    at first glance i don't see anything weird about the package name or version -- we had that issue once where python was truncating a version string that was all numbers because it started with 
    0
    (ridiculous), but that was fixed a while ago by adding the 
    git
    prefix after the 
    +
    . not sure if that's relevant here
  • h

    hundreds-father-404

    11/04/2019, 3:48 PM
    Does this reproduce locally?
    ☝️ 1
  • h

    hundreds-father-404

    11/04/2019, 3:49 PM
    One tricky thing about that wheel is it must maintain Py2 compatibility. I haven’t seen the changes past 3 weeks, but a good sanity check is to audit any changes to the contrib/python/checks folder (if any) and confirm none broke Py2 support
  • l

    limited-country-20626

    11/04/2019, 5:30 PM
    alrighty, I was commuting
  • l

    limited-country-20626

    11/04/2019, 5:30 PM
    adding a verbose flag to the shell script reveals some surprises
  • l

    limited-country-20626

    11/04/2019, 5:31 PM
    which I swear we also did last time before somehow being forced green
  • l

    limited-country-20626

    11/04/2019, 5:31 PM
    but anyway
  • l

    limited-country-20626

    11/04/2019, 5:31 PM
    Copy code
    + for package in "${packages[@]}"
++ find_pkg pantsbuild.pants 1.23.0dev0+gitd21e376c /Users/mateo/dev/pants/dist
++ local -r pkg_name=pantsbuild.pants
++ local -r version=1.23.0dev0+gitd21e376c
++ local -r search_dir=/Users/mateo/dev/pants/dist
++ find /Users/mateo/dev/pants/dist -type f -name 'pantsbuild.pants-1.23.0dev0+gitd21e376c-*.whl'
+ wheel=
+ cp -p '' /Users/mateo/dev/pants/dist/deploy/wheels/pantsbuild.pants/d21e376c9246fe7e604719d8e3876692a015a3a2/1.23.0dev0+gitd21e376c
cp: : No such file or directory
+ die 'Failed to find package pantsbuild.pants-1.23.0dev0+gitd21e376c!'
+ (( 1 > 0 ))
+ log '\n\x1b[31mFailed to find package pantsbuild.pants-1.23.0dev0+gitd21e376c!\x1b[0m'
+ echo -e '\n\x1b[31mFailed to find package pantsbuild.pants-1.23.0dev0+gitd21e376c!\x1b[0m'
  • l

    limited-country-20626

    11/04/2019, 5:31 PM
    that is the failure
  • l

    limited-country-20626

    11/04/2019, 5:33 PM
    I have this file
  • l

    limited-country-20626

    11/04/2019, 5:33 PM
    /Users/mateo/dev/pants/dist/pantsbuild.pants-1.23.0dev0+gitd21e376c/dist/pantsbuild.pants-1.23.0.dev0+gitd21e376c-cp36-abi3-macosx_10_13_x86_64.whl
  • l

    limited-country-20626

    11/04/2019, 5:35 PM
    looks like the period in the version
  • l

    limited-country-20626

    11/04/2019, 5:47 PM
    PEBKAC. Not easy to discover, the release script overwrites unstaged changes to the VERSION file. Thanks for the extra eyes and for pushing me to dig.
  • l

    limited-country-20626

    11/04/2019, 5:59 PM
    If anyone hits the error before our slack history ages out, here is the PR with deets: https://github.com/pantsbuild/pants/pull/8572
1...163164165...206Latest