https://pantsbuild.org/ logo
Powered by
#announce
  • w

    witty-crayon-22786

    01/03/2019, 9:15 PM
    @happy-kitchen-89482: speaking of which: there is a lint error on https://github.com/pantsbuild/pants/pull/7012
  • w

    witty-crayon-22786

    01/03/2019, 9:16 PM
    hm... given the criticality, i went ahead and made an edit to your branch, and am going to cancel a few other PR runs. cc @aloof-angle-91616
  • w

    witty-crayon-22786

    01/03/2019, 9:18 PM
  • h

    happy-kitchen-89482

    01/03/2019, 9:20 PM
    Yeah, that timeout on one of my other changes was why I went down that CI speedup rabbit hole to begin with…
  • h

    happy-kitchen-89482

    01/03/2019, 9:21 PM
    Another lint error? Yeesh
  • h

    happy-kitchen-89482

    01/03/2019, 10:03 PM
    And now the .travis.yml change failed precheck. Hoist by my own petard…
  • h

    happy-kitchen-89482

    01/03/2019, 10:03 PM
    fixing
  • w

    witty-crayon-22786

    01/03/2019, 10:10 PM
    heh. would recommend actually installing the precommit hooks locally.
  • w

    witty-crayon-22786

    01/03/2019, 10:10 PM
    can easily skip them with 
    -n
  • w

    witty-crayon-22786

    01/03/2019, 10:10 PM
    but they catch things all the time.
  • a

    aloof-angle-91616

    01/03/2019, 10:11 PM
    i fixed the pre-commit hook today if you just so happened to have it turned off because of a pexrc issue
  • w

    witty-crayon-22786

    01/03/2019, 10:16 PM
    i never saw that issue for some reason
  • w

    witty-crayon-22786

    01/03/2019, 10:16 PM
    but thank you.
  • a

    aloof-angle-91616

    01/03/2019, 10:16 PM
    daniel saw it once and i started seeing it recently so i'm going to put it down to background magic happening on work laptops
  • w

    witty-crayon-22786

    01/04/2019, 1:13 AM
    Benjy: looks like you're about to go green with the exception of one known flaky test. going to merge when i see it.
  • h

    happy-kitchen-89482

    01/04/2019, 1:46 AM
    Ah I didn’t know that was known flaky, so I restarted it
  • h

    happy-kitchen-89482

    01/04/2019, 1:47 AM
    Weeeeee!
  • h

    happy-kitchen-89482

    01/04/2019, 1:47 AM
    Thanks for merging
    🍾 2
  • e

    enough-analyst-54434

    01/04/2019, 11:15 PM
  • e

    enough-analyst-54434

    01/05/2019, 2:13 AM
  • a

    aloof-angle-91616

    01/05/2019, 9:23 PM
    @enough-analyst-54434 thanks a ton for actually addressing the beautiful soup warning in https://github.com/pantsbuild/pants/pull/7027, i had kept meaning to do it and not writing it down
    ❤️ 1
  • e

    enough-analyst-54434

    01/07/2019, 4:33 PM
    You're welcome!
  • l

    limited-country-20626

    01/12/2019, 2:53 AM
    I am gonna start on the 1.4.0dev2 release now
    👍 2
  • l

    limited-country-20626

    01/14/2019, 3:26 AM
    so, after wasting more time than I care to admit, turns out that the Pants codebase chokes on an OSX box if pantsbuild.pants is installed on the system
    😖 2
  • l

    limited-country-20626

    01/14/2019, 3:26 AM
    (and is a different version)
  • l

    limited-country-20626

    01/14/2019, 3:27 AM
    maybe this is by design to support pex distributions of Pants
  • l

    limited-country-20626

    01/14/2019, 3:27 AM
    anyway
  • l

    limited-country-20626

    01/14/2019, 3:28 AM
    Copy code
    from pants.init.subprocess import Subprocess
                     E   ImportError: No module named init.subprocess
  • l

    limited-country-20626

    01/14/2019, 3:28 AM
    among others. This is because I had a pip install on my system pip
  • l

    limited-country-20626

    01/14/2019, 3:28 AM
    probably from smoketesting a previous release, which I made a habit of after I announced an upgrade that didn't include all the modules
1...145146147...206Latest