https://pantsbuild.org/ logo
Powered by
#announce
  • e

    enough-analyst-54434

    10/05/2018, 4:20 PM
    I'll confirm with him though and take it if he cannot.
  • e

    enough-analyst-54434

    10/05/2018, 4:20 PM
    Ah yes - my fix in pex is here:
  • e

    enough-analyst-54434

    10/05/2018, 4:21 PM
  • w

    witty-crayon-22786

    10/05/2018, 4:21 PM
    thanks.
  • e

    enough-analyst-54434

    10/05/2018, 4:21 PM
    I need to take the time in pex to see if we really need to be using jupyter as a proxy for whatever the heck we're testing
  • e

    enough-analyst-54434

    10/05/2018, 4:22 PM
    Simillar analysis in Pants may say ditch it
  • w

    witty-crayon-22786

    10/06/2018, 1:25 AM
    hm. the combination of two earlier PRs might have broken the rust tests on master. i will attempt to fix those in an hour.
  • h

    hundreds-father-404

    10/06/2018, 1:46 AM
    Our CI is too slow to really consider this but I wish we could require always being up-to-date against master
    a
    • 2
    • 24
  • w

    witty-crayon-22786

    10/06/2018, 2:12 AM
    please do not merge until https://github.com/pantsbuild/pants/pull/6602 goes in. i will likely only wait for the two rust shards to complete before merging.
    👍 1
    • 1
    • 1
  • l

    limited-country-20626

    10/06/2018, 2:47 AM
    I am gonna start putting together the release. Review will be up later tonight, and I will push when it is approved/green
    👍 2
  • l

    limited-country-20626

    10/06/2018, 6:52 PM
    I don't know what it means that the commit was landed by stu
  • l

    limited-country-20626

    10/06/2018, 6:52 PM
    I was waiting for an approval but I am going to assume that means the release process has been adopted for now
  • l

    limited-country-20626

    10/07/2018, 1:42 AM
    I haven't seen a release email but still a little reluctant to release - I think pypi protects against overwriting pushes but I am not sure. @witty-crayon-22786 any update on what the status is
  • w

    witty-crayon-22786

    10/07/2018, 1:52 AM
    @limited-country-20626: i just landed it for you so you wouldn't have to update the release notes if someone else landed something
  • w

    witty-crayon-22786

    10/07/2018, 1:52 AM
    I didn't run the pypi release steps.
  • w

    witty-crayon-22786

    10/07/2018, 1:53 AM
    Sorry for the confusion.
  • w

    witty-crayon-22786

    10/07/2018, 1:55 AM
    So you're at "3. Publish to PyPi" on https://www.pantsbuild.org/release.html
  • w

    witty-crayon-22786

    10/07/2018, 1:56 AM
    (and if things have landed in master since the notes, you can use the reset command it recommends there)
  • l

    limited-country-20626

    10/07/2018, 6:55 PM
    I was surprised that it landed, my guess was that you needed a release ASAP for internal reasons
    a
    • 2
    • 1
  • l

    limited-country-20626

    10/07/2018, 6:56 PM
    I considered landing it TBR on friday night, for those same reasons
  • a

    aloof-angle-91616

    10/10/2018, 7:46 PM
    1.10.0rc2 notes: https://github.com/pantsbuild/pants/pull/6615. we are testing this change internally now after the most recent commit -- all the logging fixes have been working as expected.
  • a

    aloof-angle-91616

    10/11/2018, 4:43 AM
    1.10.x
    continues to fail shard 3: https://travis-ci.org/pantsbuild/pants/builds/439800324, i've blasted caches and restarted three times. unclear how this happened, since it looks like when the change was made it passed CI? (https://travis-ci.org/pantsbuild/pants/builds/434363409 passed on the first commit of https://github.com/pantsbuild/pants/pull/6568) 
    ./pants test tests/python/pants_test/backend/python/tasks: -- -vs -k pex_resolver_blacklist_integ
    should also fail on your machine. i'm trying to pin other versions but i'm not finding i'm able to figure out why this suddenly stopped working. i also ran 
    rm -rf .cache dist .pants.d build-support/pants_dev_deps.venv ~/.cache/pants/python_cache ~/.pex
    and tried again and it still failed
  • a

    aloof-angle-91616

    10/11/2018, 4:52 AM
    i added 
    jupyter-console<6
    for funsies and then just got
    Copy code
    Exception message: Could not satisfy all requirements for prompt-toolkit<2.0.0,>=1.0.4:
                     E              prompt-toolkit<2.0.0,>=1.0.4(from: ipython<6), prompt-toolkit<2.1.0,>=2.0.0(from: jupyter-console<6)
  • a

    aloof-angle-91616

    10/11/2018, 5:19 AM
    this is probably an obvious issue but like outside of some dependency ordering thing i'm not getting or like some intermediate version being removed in the interim -- not sure of how best to investigate
    e
    • 2
    • 8
  • a

    aloof-angle-91616

    10/11/2018, 4:21 PM
    build for 1.10.x going which fixes the issue above thanks to john reminding me about the almighty pickaxe: https://travis-ci.org/pantsbuild/pants/builds/440226258
  • a

    aloof-angle-91616

    10/11/2018, 4:21 PM
    (or at least, it was failing locally with the same error, and now it's not)
  • h

    happy-kitchen-89482

    10/12/2018, 7:14 PM
    I’m the release human today. Let me know if you have any outstanding changes you want me to wait for. Otherwise I’ll cut in a couple of hours, probably.
  • a

    aloof-angle-91616

    10/12/2018, 7:16 PM
    this is not relevant to the benjy release note to self to make a notes diff for 1.10.0rc2 again incorporating the commit i cherry-picked to fix the resolve error in the pex integration test to fix travis for 1.10.x
  • s

    salmon-summer-38098

    10/12/2018, 7:20 PM
    @aloof-angle-91616 let me know if you would like me to …
  • h

    happy-kitchen-89482

    10/12/2018, 7:20 PM
    you wouldn’t be able to have a global interpreter constraint, for example
    a
    • 2
    • 1
1...136137138...206Latest