https://pantsbuild.org/ logo
Powered by
#announce
  • a

    aloof-angle-91616

    09/18/2018, 12:35 AM
    failing to fetch llvm on a timeout has happened a few times -- it seems like something that could be addressed in 
    BinaryUtil
  • a

    aloof-angle-91616

    09/18/2018, 12:36 AM
    the other will be fixed when the go meta retries PR is finished
  • a

    aloof-angle-91616

    09/18/2018, 12:37 AM
    while that CI finishes i can review the docs for a stable release
  • a

    aloof-angle-91616

    09/18/2018, 1:01 AM
    the 1.8.0 release has the additional description:
    Includes helpful new features like the --owner-of option for selecting targets by owned filename, and warnings/errors for unmatched globs. Additionally, updates Pants' usage of the zinc incremental Scala compiler to a 1.0.x release.
    (https://www.pantsbuild.org/notes-1.8.x.html) -- is that something that should be/needs to be added to the 1.9.0 release?
  • a

    aloof-angle-91616

    09/18/2018, 1:02 AM
    fixing glob matching is a big one if we mentioned the glob matching already in 1.8.0
  • a

    aloof-angle-91616

    09/18/2018, 1:03 AM
    (fixing it to not error if only one of the default sources globs expands to something)
  • a

    aloof-angle-91616

    09/18/2018, 1:06 AM
    also you don't need to 
    clean-all
    in between runs of a 
    python_dist()
    anymore
  • a

    aloof-angle-91616

    09/18/2018, 1:06 AM
    and native thirdparty but that's still experimental
  • a

    aloof-angle-91616

    09/18/2018, 1:08 AM
    oh no that made it into 1.8.0! that's so awesome omg
  • a

    aloof-angle-91616

    09/18/2018, 1:09 AM
    i was barely falling asleep at night thinking 1.8.0 users were seeing warnings on their perfectly valid targets
  • a

    aloof-angle-91616

    09/18/2018, 1:10 AM
    i don't see anything immediately obvious to add but i'll just post the empty notes PR and anyone can comment
  • a

    aloof-angle-91616

    09/18/2018, 1:18 AM
  • w

    witty-crayon-22786

    09/18/2018, 4:07 PM
    @salmon-summer-38098: rather than reverting https://github.com/pantsbuild/pants/pull/6509, you could maybe just go ahead and land the notes in master
  • w

    witty-crayon-22786

    09/18/2018, 4:07 PM
    would be two PRs, but that's ok.
  • s

    salmon-summer-38098

    09/18/2018, 4:35 PM
    @witty-crayon-22786 sounds good to me! It would have been much easier to just 
    reset HEAD
    on the 1.10.x branch but wanted to send that out for visibility
  • s

    salmon-summer-38098

    09/18/2018, 4:35 PM
    2nd pr for landing in master makes sense
  • a

    aloof-angle-91616

    09/18/2018, 6:29 PM
    i've merged the (empty) notes change into master and cherry-picked it onto 1.9.x, and pushed that to pantsbuild/pants. i'm ready to do the 1.9.0 release but not impatient
  • a

    average-vr-56795

    09/18/2018, 6:37 PM
    @witty-crayon-22786 I’m expecting https://github.com/pantsbuild/pants/pull/6503 to go green - PTAL when convenient 🙂
    w
    f
    • 3
    • 63
  • w

    witty-crayon-22786

    09/18/2018, 6:43 PM
    @average-vr-56795: thanks a lot! #shipit.
  • a

    aloof-angle-91616

    09/18/2018, 6:47 PM
    i'm going to be involved in things taking my attention until at least 3pm california time and i'm thinking of doing the 1.9.0 release around then
  • w

    witty-crayon-22786

    09/18/2018, 7:05 PM
    anytime. the branch won't change.
  • a

    aloof-angle-91616

    09/18/2018, 9:25 PM
    ok then trying now
  • w

    witty-crayon-22786

    09/18/2018, 9:27 PM
    the only consideration is that travis' networking is currently very flaky
  • a

    aloof-angle-91616

    09/18/2018, 9:27 PM
    working through that right now
  • a

    aloof-angle-91616

    09/18/2018, 9:28 PM
    i strongly doubt this failure isn't spurious but i'm not sure what would cause it other than a corrupted python install? https://travis-ci.org/pantsbuild/pants/jobs/430184124
  • a

    aloof-angle-91616

    09/18/2018, 9:30 PM
    Copy code
    error: failed to run custom build command for `engine v0.0.1 (file:///home/travis/build/pantsbuild/pants/src/rust/engine)`
process didn't exit successfully: `/home/travis/build/pantsbuild/pants/src/rust/engine/target/debug/build/engine-1ca951c3d239aab9/build-script-cffi_build` (exit code: 1)
--- stdout
cargo:rustc-link-lib=static=stdc++
cargo:rerun-if-changed=/home/travis/build/pantsbuild/pants/build-support/bin/native/bootstrap_cffi.sh
cargo:rerun-if-changed=/home/travis/build/pantsbuild/pants/src/python/pants/engine/native.py
cargo:rerun-if-changed=src/cffi/native_engine.c
cargo:rerun-if-changed=src/cffi/native_engine.cflags
--- stderr
Traceback (most recent call last):
  File "/home/travis/build/pantsbuild/pants/build-support/pants_dev_deps.venv/lib/python2.7/site.py", line 67, in <module>
    import os
  File "/home/travis/build/pantsbuild/pants/build-support/pants_dev_deps.venv/lib/python2.7/os.py", line 49, in <module>
    import posixpath as path
  File "/home/travis/build/pantsbuild/pants/build-support/pants_dev_deps.venv/lib/python2.7/posixpath.py", line 17, in <module>
    import warnings
ImportError: No module named warnings
Execution of "/home/travis/build/pantsbuild/pants/build-support/bin/native/bootstrap_cffi.sh" failed with exit code Some(1)
warning: build failed, waiting for other jobs to finish...
error: build failed
Pants rust test failure
  • w

    witty-crayon-22786

    09/18/2018, 9:30 PM
    probably just flakiness.
  • a

    aloof-angle-91616

    09/18/2018, 9:30 PM
    yeah
  • a

    aloof-angle-91616

    09/18/2018, 9:30 PM
    just weird
  • a

    aloof-angle-91616

    09/18/2018, 9:30 PM
    i doubt it's non-flaky
1...134135136...206Latest