https://pantsbuild.org/ logo
Powered by
#announce
  • w

    witty-crayon-22786

    09/10/2018, 11:14 PM
    https://travis-ci.org/pantsbuild/pants/jobs/426861363 ... i'm surprised the doc site publish worked... did you have to edit it?
  • s

    salmon-summer-38098

    09/10/2018, 11:15 PM
    oh yeah, i am just sending the review for it
  • s

    salmon-summer-38098

    09/10/2018, 11:16 PM
    and no, the docsite was the one that error'd at the end of the release script ^ see my comments above
  • w

    witty-crayon-22786

    09/10/2018, 11:16 PM
    ah. missed that.
  • w

    witty-crayon-22786

    09/10/2018, 11:17 PM
    @salmon-summer-38098: can test locally with 
    build-support/bin/publish_docs.sh -o
  • s

    salmon-summer-38098

    09/10/2018, 11:17 PM
    oh wait, back track - I was able to publish successfully after making local edits
  • s

    salmon-summer-38098

    09/10/2018, 11:21 PM
  • s

    salmon-summer-38098

    09/10/2018, 11:21 PM
    ^can anyone look at this quickly?
  • s

    salmon-summer-38098

    09/10/2018, 11:22 PM
    as in it should be quick to look at 🙂
  • a

    aloof-angle-91616

    09/10/2018, 11:38 PM
  • a

    aloof-angle-91616

    09/11/2018, 4:52 AM
    merged the notes diff, pushed the version bump, doing a dry run, wanna wait until tomorrow to do the release under the potential possibility that if something horrible happens someone else nearby will notice it
  • a

    aloof-angle-91616

    09/11/2018, 4:57 AM
    (dry run passed, obviously)
  • a

    aloof-angle-91616

    09/11/2018, 5:26 PM
    it is now the morning in this small slice of the world so i will attempt a 1.9.0rc3 release now
  • a

    aloof-angle-91616

    09/11/2018, 5:44 PM
    it's up on pypi, packages aren't available for download yet https://pypi.org/project/pantsbuild.pants/1.9.0rc3/
    e
    • 2
    • 8
  • a

    aloof-angle-91616

    09/11/2018, 5:48 PM
    release test passed, wheels are available. pants-devel post time
    🎉 1
  • a

    aloof-angle-91616

    09/12/2018, 3:27 AM
    merging this to make CI work: https://github.com/pantsbuild/pants/pull/6493
  • a

    aloof-angle-91616

    09/12/2018, 3:29 AM
    also i never sent out the pants-devel message, that's very embarrassing
  • a

    aloof-angle-91616

    09/12/2018, 3:29 AM
    no time like the present
  • a

    aloof-angle-91616

    09/12/2018, 3:36 AM
    i'm going to do a doc publish from master to get the 1.9.0rc3 notes up, because the doc publish script doesn't do that if you're not on master (thinking of ways to automate much more of this process)
  • a

    aloof-angle-91616

    09/12/2018, 3:51 AM
    done
  • a

    aloof-angle-91616

    09/12/2018, 3:51 AM
  • a

    aloof-angle-91616

    09/12/2018, 3:53 AM
  • a

    aloof-angle-91616

    09/12/2018, 3:55 AM
    i noted that this is the last release candidate, i've managed to get the nailgun error to repro again internally so as stu mentioned that sounds like a great excuse for 1.9.1 (and i have a definite fix for that, i just got confused when i couldn't repro the issue anymore)
  • a

    aloof-angle-91616

    09/12/2018, 5:54 AM
    does anyone have any insight into why something that clearly shouldn't pass lint was somehow able to get past the pre-commit hook? see my comment here https://github.com/pantsbuild/pants/pull/6494#issuecomment-420520850 like it seems blatantly incorrect if not actually blocking me
  • w

    witty-crayon-22786

    09/17/2018, 8:58 PM
    @aloof-angle-91616: no rush at all, but enough time has passed to cut 1.9.0 final probably
  • a

    aloof-angle-91616

    09/17/2018, 8:58 PM
    oh heck yes
  • a

    aloof-angle-91616

    09/17/2018, 8:58 PM
    i can do that today at some point
  • w

    witty-crayon-22786

    09/17/2018, 9:00 PM
    yep, no rush
  • a

    aloof-angle-91616

    09/18/2018, 12:29 AM
    i haven't been able to reliably repro the error that https://github.com/pantsbuild/pants/pull/6388 fixes again, but we're still seeing it internally, so i'm thinking of merging that now since it definitely fixes something thanks to testing/review, and backporting that patch to a 1.9.1 release, and then making the 1.9.0 release now
  • a

    aloof-angle-91616

    09/18/2018, 12:31 AM
    it says its red but i just rebased it since last time so it's prob spurious but checking now, won't merge before it's green
1...133134135...206Latest