#announce
- h
happy-kitchen-89482
08/27/2018, 11:27 PMTrue, but pushing from my desktop to master feels dangerous - w
witty-crayon-22786
08/27/2018, 11:27 PM@happy-kitchen-89482: let me know when we're good to land other things. - h
happy-kitchen-89482
08/27/2018, 11:27 PMAdded a couple of commits to the release, in case you want to re-review the updated notes: https://github.com/pantsbuild/pants/pull/6396 - h
happy-kitchen-89482
08/27/2018, 11:27 PMOnce that’s green I will merge it. - w
witty-crayon-22786
08/27/2018, 11:28 PMlooks good. - h
happy-kitchen-89482
08/28/2018, 1:40 AMI have to run, and it’s still yellow (I think some shards are going to time out). Will get back to this when I get back home later. - h
happy-kitchen-89482
08/28/2018, 1:40 AMIf it goes green and you want to merge it, feel free. - h
happy-kitchen-89482
08/28/2018, 1:40 AMThen I can actually publish the release later. - h
happy-kitchen-89482
08/28/2018, 4:17 AMthanks for merging - h
happy-kitchen-89482
08/28/2018, 4:17 AMwill publish now🚢 2 - h
happy-kitchen-89482
08/28/2018, 4:47 AMRelease is live, finally.🎉 3 - w
witty-crayon-22786
08/28/2018, 6:26 PM@aloof-angle-91616: i'm going to pick the 1.8.x stuff from https://github.com/pantsbuild/pants/issues?utf8=%E2%9C%93&q=label%3Aneeds-cherrypick+ to the 1.8.x branch... but anything that needs picking to 1.8.x also needs picking to 1.9.x - w
witty-crayon-22786
08/28/2018, 6:26 PMso you should probably take that - a
aloof-angle-91616
08/28/2018, 6:28 PMok, that sounds good. https://github.com/pantsbuild/pants/pull/6388 looks good enough and could also use testing and i just can't figure out how to do that right now (i have spent maybe an hour thinking about this and could easily spend more) - w
witty-crayon-22786
08/28/2018, 6:29 PMif we haven't had any additional repros of that issue, it may not be worth including - w
witty-crayon-22786
08/28/2018, 6:30 PMup to you. if it's harmless, then there is also not much harm in including it. - w
witty-crayon-22786
08/28/2018, 6:30 PM@aloof-angle-91616: ^ - a
aloof-angle-91616
08/28/2018, 6:31 PMthat's what i was thinking - a
aloof-angle-91616
08/28/2018, 6:31 PMespecially since every log we have of the issue has the version string 1.8.0rc0 in it - a
aloof-angle-91616
08/28/2018, 6:33 PMi think it is a useful change to have but it's not clear it's a required hotfix since we haven't had any reports since the hotfix was made internally so i'm on the side of leave it open for now, finish the path globs issue for 1.8.x, then finish the 1.9.0 release and decide whether that logging change is necessary as a hotfix - w
witty-crayon-22786
08/28/2018, 6:35 PMreasonable. - w
witty-crayon-22786
08/28/2018, 6:35 PMwill drop the label - a
aloof-angle-91616
08/28/2018, 6:36 PMgr9 - a
aloof-angle-91616
08/28/2018, 6:39 PMfocusing on this PR for now until it passes: https://github.com/pantsbuild/pants/pull/6278. i have an appointment from 1-2pm today but "get the 1.9.0 release ready" is very actionable and clear and i should be able to get things moving soon - w
witty-crayon-22786
08/28/2018, 6:57 PM@aloof-angle-91616: also, this one is targeted at 1.8.x: https://github.com/pantsbuild/pants/issues/6394 is that intentional? - a
aloof-angle-91616
08/28/2018, 6:58 PMi believe john moved it into there because it repros there but would need to check -- i can do that now - w
witty-crayon-22786
08/28/2018, 6:58 PMi guess there is no fix right now, so it's moot - w
witty-crayon-22786
08/28/2018, 6:58 PM@aloof-angle-91616: sorry, asked that thinking it was a pr - a
aloof-angle-91616
08/28/2018, 6:58 PMit should be - a
aloof-angle-91616
08/28/2018, 6:59 PMthe necessary changes aren't huge at all