#announce
- e
enough-analyst-54434
08/20/2018, 10:03 PMSure - I guess. I'm totally OK with it getting merged but its a bit odd Chris wouldn't be the merger - e
enough-analyst-54434
08/20/2018, 10:04 PMHe's a committer IIRC - w
witty-crayon-22786
08/20/2018, 10:06 PMhe's not - e
enough-analyst-54434
08/20/2018, 10:06 PMAha, fire away then! - w
witty-crayon-22786
08/20/2018, 10:06 PMmerged - w
witty-crayon-22786
08/20/2018, 10:20 PM(... i think he's a pex committer, but not yet a pants committer.) - w
witty-crayon-22786
08/20/2018, 10:21 PM(note to self) - w
witty-crayon-22786
08/20/2018, 10:22 PM(although you could totally nominate!) - e
enough-analyst-54434
08/20/2018, 11:40 PM - h
hundreds-father-404
08/21/2018, 3:24 AMThis test failure looks relevant to release, https://travis-ci.org/pantsbuild/pants/jobs/418511123 - e
enough-analyst-54434
08/21/2018, 4:02 AMSeems a bit unlikely since there have been two master branch greens post release.h- 2
- 1
- h
happy-kitchen-89482
08/24/2018, 10:22 PMI’ll get cracking on the release later today, or tomorrow - h
happy-kitchen-89482
08/24/2018, 11:29 PM - h
happy-kitchen-89482
08/26/2018, 5:58 PMNote that the release is on hold due to problems with the OSX rust build💔 2h- 2
- 3
- h
happy-kitchen-89482
08/27/2018, 6:14 PM👍 1 - h
happy-kitchen-89482
08/27/2018, 6:14 PMI will push the build fix separately - h
happy-kitchen-89482
08/27/2018, 6:14 PMthen you should be able to get both those passing - h
happy-kitchen-89482
08/27/2018, 6:14 PMI’ll release later this afternoon - h
happy-kitchen-89482
08/27/2018, 6:18 PM - h
hundreds-father-404
08/27/2018, 7:45 PMI’m boarding flight now. If I have internet on flight I’ll rebase, otherwise won’t be able to today (no worries, don’t have that block release) - w
witty-crayon-22786
08/27/2018, 9:59 PM@happy-kitchen-89482: https://github.com/pantsbuild/pants/pull/6402 is green- 1
- 1
- h
happy-kitchen-89482
08/27/2018, 11:16 PMOh good, it wasn’t last I checked - h
happy-kitchen-89482
08/27/2018, 11:16 PMdid you re-run something?w- 2
- 1
- h
happy-kitchen-89482
08/27/2018, 11:17 PMOh, turns out rebase without squash is disabled for our repo, ah wellw- 2
- 3
- h
happy-kitchen-89482
08/27/2018, 11:18 PMOK, so that’s in master - w
witty-crayon-22786
08/27/2018, 11:19 PMthanks. release needs a rebase, and then you'll probably want to just go ahead and land it - w
witty-crayon-22786
08/27/2018, 11:19 PMthere are a few other PRs i want to land afterward. - h
happy-kitchen-89482
08/27/2018, 11:22 PMI just merged https://github.com/pantsbuild/pants/pull/6373 so I’ll add that to the release (since I have to pull the CI fix anyway) - e
enough-analyst-54434
08/27/2018, 11:24 PMThe merge button is evil ;) ! Bad training. You can still use good old git to do this without turning off squash for the merge button temporarily. - w
witty-crayon-22786
08/27/2018, 11:26 PM...possibly. origin might reject it, although i haven't triede- 2
- 3