pantsbuild #announce

Channels

welcome

github-notifications

development

enough-analyst-54434

07/17/2018, 1:32 AM

So not like which

hundreds-father-404

07/17/2018, 1:33 AM

Nice, I had no idea that was a thing. Thanks

hundreds-father-404

07/17/2018, 1:39 AM

I’ll try bumping isort version to 4.3.4 and running on foursquare Travis to test. That may potentially solve the immediate problem. Added benefit that we also do want

queue

and the other imports to be seen as standard lib, so in this case CI is less ideal version

enough-analyst-54434

07/17/2018, 1:43 AM

edits to

.isort.cfg

with comments pointing off to an issue are also fine to unblock.

enough-analyst-54434

07/17/2018, 1:43 AM

I can push 4.3.4 up to binaries.pantsbuild.org

hundreds-father-404

07/17/2018, 1:45 AM

I’m not sure what the reason is for that - I’m not very familiar with how Pants pulls its requirements? I thought it was from Pypi

enough-analyst-54434

07/17/2018, 1:45 AM

It is not, we pre-build a pex

enough-analyst-54434

07/17/2018, 1:45 AM

so we download 1 file instead of on-the fly installing isort's dep graph

hundreds-father-404

07/17/2018, 1:46 AM

Ah okay, that would be great On my end, I only have to update

3rdparty/python/requirements.txt

, correct?

enough-analyst-54434

07/17/2018, 1:47 AM

That won't affect pant's fmt.isort goal which is what is running via ./build-support/bin/isort.sh

enough-analyst-54434

07/17/2018, 1:47 AM

That goal uses the pre-built isort.pex

enough-analyst-54434

07/17/2018, 1:47 AM

That repo is pantsbuild/binaries

enough-analyst-54434

07/17/2018, 1:48 AM

Unfortunately, this is not self serve (in any easy way) - we do allow adding extra binaries.pantsbuild.org - styl urls, one of which could be a local filesystem, etc

enough-analyst-54434

07/17/2018, 1:48 AM

But no need to go there

hundreds-father-404

07/17/2018, 1:49 AM

Hm okay, is there an alternative way to check if bumping to 4.3.4 will work? If not, agreed that we can add to

known_standard_library

under isort settings

enough-analyst-54434

07/17/2018, 1:50 AM

Well, inspection of the code I linked to isrot/settings.py

enough-analyst-54434

07/17/2018, 1:50 AM

I'll re-stress edits to

.isort.cfg

with comments pointing off to an issue are also fine to unblock.

enough-analyst-54434

07/17/2018, 1:50 AM

So do that!

enough-analyst-54434

07/17/2018, 1:51 AM

https://github.com/timothycrosley/isort#configuring-isort

enough-analyst-54434

07/17/2018, 1:51 AM

known_standard_library=...,...,

hundreds-father-404

07/17/2018, 1:52 AM

Okay, if it’s easier to do than upgrading the isort pex, I can go ahead and do that. I typically prefer avoiding adding lots of custom settings, although I think either approach works.

hundreds-father-404

07/17/2018, 1:52 AM

I agree we shouldn’t let this block

hundreds-father-404

07/17/2018, 2:50 AM

This will fix isort issues https://github.com/pantsbuild/pants/pull/6148. Thanks @enough-analyst-54434 for helping out so much with debugging!

enough-analyst-54434

07/17/2018, 3:01 AM

Thank you!

aloof-angle-91616

07/19/2018, 4:31 AM

I added the bugfix #6181 to the

1.9.0rc0

release PR (https://github.com/pantsbuild/pants/pull/6171) -- planning to merge soon and then release to pypi tomorrow morning in california time

🎉 1

witty-crayon-22786

07/19/2018, 4:33 AM

👍

witty-crayon-22786

07/19/2018, 4:46 AM

@aloof-angle-91616: er... i got an email saying something else. i guess you deleted that comment?

aloof-angle-91616

07/19/2018, 4:46 AM

yes!

witty-crayon-22786

07/19/2018, 4:46 AM

This is unchanged since the most recent commit, as the bugfix from #6181 only fixes a bug introduced since 1.9.0.dev1. Accordingly, I will merge this change tomorrow morning unless someone says it's ok to do it earlier.

aloof-angle-91616

07/19/2018, 4:46 AM

realizing it was a horrible idea