@enough-analyst-54434: https://github.com/pantsbuild/pants/pull/6012

Thanks Stu, I will gratefully mooch that, but my work will bleed into Monday. I have a rare opportunity to get out and about "hiking" in my wheelchair tomorrow I'm going to take full advantage of.

hope it was a lovely (st)roll!

heh

Ha!

https://pypi.org/project/pantsbuild.pants/1.9.0.dev0 https://groups.google.com/d/topic/pants-devel/Mg3mncBD8PM/discussion

woot!

The backstory is

egg_info --tag-build <suffix>

is a standard setuptools command that can be prefixed to sdist, bdist_wheel, etc to change the distribution version at build time. Given that bit of technology and this code in pants:

try:
  # We're running from a `pantsbuild.pants` distribution which may have a custom version applied at
  # build time.
  VERSION = pkg_resources.get_distribution('pantsbuild.pants').version
except pkg_resources.DistributionNotFound:
  # We're running from bare sources.
  VERSION = pkgutil.get_data(__name__, 'VERSION').strip()

... does anyone gack? does anyone cheer?

wfm

cool, this should take a little ingenious hackery out of our codebase

wfm

works for me assuming it's using the same input file (...and why wouldn't it be)

it's using the same input file

It's == setuptools and file == setup.py? or more particularly this line?:

pkg_resources.get_distribution('pantsbuild.pants').version

... not sure what your pronouns refer to @witty-crayon-22786

src/python/pants/VERSION

is the version

one place to change it, multiple places to read the file from

nope

that would be read via the

pkg_resources.Distribution

API:

[omerta source (master)]$ PEX_INTERPRETER=1 ./pants
Python 2.7.14 (default, Nov 16 2017, 13:57:42) 
[GCC 4.2.1 Compatible Apple LLVM 8.0.0 (clang-800.0.42.1)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
(InteractiveConsole)
>>> import pkg_resources
>>> pants_dist = pkg_resources.get_distribution('pantsbuild.pants')
>>> pants_dist
pantsbuild.pants 1.8.0rc0+26394df2 (/Users/kwilson/dev/source/.pex/install/pantsbuild.pants-1.8.0rc0+26394df2-cp27-none-macosx_10_11_x86_64.whl.8e3a3639d08ef0818f4f5cb4ae4c20e5709cf325/pantsbuild.pants-1.8.0rc0+26394df2-cp27-none-macosx_10_11_x86_64.whl)
>>> type(pants_dist)
<class 'pkg_resources.DistInfoDistribution'>
>>> pants_dist.version
'1.8.0rc0+26394df2'

VERSION is now immutable

Only +suffix via command line build-time

Distribution

as in sdist, bdist

and via standard tools, hashing etc taken care of

Yes

But yes, multiple reads as in 2, from ./pants source mode (except clause above), from release.sh script

in source mode it would use the file, in binary mode, something else?

yes, in binary mode it uses the try clause

aka reads distribution metadata

which, when built with +suffix

will seal in that suffix

seal in the dist