pantsbuild #announce

Channels

welcome

github-notifications

development

witty-crayon-22786

06/07/2018, 12:46 AM

works on any non-PR sha built by travis (tag, branch, etc)

rough-minister-58256

06/07/2018, 12:57 AM

would be cool to start generating those per tagged release and including them on the github release like we do for pex: https://github.com/pantsbuild/pex/releases/tag/v1.4.3

rough-minister-58256

06/07/2018, 12:58 AM

vs our current source tarballs only: https://github.com/pantsbuild/pants/releases/tag/release_1.8.0.dev2

witty-crayon-22786

06/07/2018, 1:18 AM

waaaaaaat it automatically creates release tarballs?1?!

witty-crayon-22786

06/07/2018, 1:18 AM

...um, yes. we should.

rough-minister-58256

06/07/2018, 5:35 AM

then bootstrapping a pants pex’ via some new pantsbuild/setup logic as dogfood would be e.g.

wget <https://github.com/pantsbuild/pants/releases/download/v1.7.0rc0/pants.pex>

rough-minister-58256

06/07/2018, 5:36 AM

release tarballs as in, a tarball of the git repo @ the tag sha

rough-minister-58256

06/07/2018, 5:37 AM

but you can attach whatever arbitrary files to those “release” pages

rough-minister-58256

06/07/2018, 5:37 AM

works great for pex

enough-analyst-54434

06/07/2018, 9:24 AM

Since I'm on the release.sh warpath, I'd be happy to continue past eliminating our sdist publishing hack to pex generation and publishing to GitHub releases. I'll ping again in the am to see if that makes sense to you all.

👍 1

🔥 1

👖 1

rough-minister-58256

06/07/2018, 5:32 PM

sgtm. I was sort of thinking we should dual-path that for a trial/cutover period, but thinking more along the sdist-with-bins hack as parity its likely that a pex would be a more than suitable drop-in replacement from day 1?

rough-minister-58256

06/07/2018, 5:33 PM

might be good to have someone lined up to quickly consume/kick tires on this change at least

witty-crayon-22786

06/07/2018, 5:39 PM

my impression from yesterday was that one of @limited-country-20626, @brash-oxygen-26029 would likely be interested. but Chris has some release bumping to do to get caught up, so would need to use the release script back to when those options were initially added

witty-crayon-22786

06/07/2018, 5:41 PM

...which looks like was in time for the 1.5.0 release(s) (1.4.0.dev20-something)

rough-minister-58256

06/07/2018, 5:42 PM

could probably dual path that at least based on existence of a pex for some given version e.g.

if $(wget .../pants.pex) -> new else -> old

enough-analyst-54434

06/07/2018, 6:33 PM

Alrighty, I'll proceed down this path then, I agree publishing wheels and pexes in tandem is the way to go at least short term. There is a good deal of change in the release script (contrib testing) and the pantsbuild/setup script and it would be nice from my perspective not to big bang all that.

rough-minister-58256

06/07/2018, 6:50 PM

indeed

limited-country-20626

06/08/2018, 7:33 PM

=hosting on github

limited-country-20626

06/08/2018, 7:33 PM

I abuse that all over the place 🙂

fancy-queen-20734

06/08/2018, 10:49 PM

I’m thinking of doing the 1.7.0 release on monday. Does that make sense?

fancy-queen-20734

06/08/2018, 10:51 PM

cutting an rc1 right now

fancy-queen-20734

06/08/2018, 10:59 PM

https://github.com/pantsbuild/pants/pull/5942

rough-minister-58256

06/08/2018, 11:08 PM

🚢

fancy-queen-20734

06/09/2018, 12:04 AM

do folks wait for travis ci for the release notes PR?

rough-minister-58256

06/09/2018, 12:06 AM

its generally a good idea, yeah. I once skipped CI because of a traffic jam and it ended up breaking master because of a poorly placed space in the rst 😞

rough-minister-58256

06/09/2018, 12:08 AM

https://github.com/pantsbuild/pants/pull/5687/files

rough-minister-58256

06/09/2018, 12:08 AM

heh

fancy-queen-20734

06/09/2018, 12:14 AM

lol. I remember that one

rough-minister-58256

06/09/2018, 12:15 AM

heh

rough-minister-58256

06/09/2018, 12:16 AM

never wouldve thought one innocuous space like that would break the parser